third_party/WebKit/Source/core/html/forms/TextFieldInputType.cpp - Issue 1478573002: Double-clicking whitespace after value text should select the last word in INPUT/TEXTAREA.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/forms/TextFieldInputType.cpp

Issue 1478573002: Double-clicking whitespace after value text should select the last word in INPUT/TEXTAREA. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/html/HTMLTextAreaElement.cpp ('k') | third_party/WebKit/Source/core/layout/LayoutTextControl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/html/forms/TextFieldInputType.cpp

diff --git a/third_party/WebKit/Source/core/html/forms/TextFieldInputType.cpp b/third_party/WebKit/Source/core/html/forms/TextFieldInputType.cpp

index f32305b46c52de7728722c866fc152c70bdf4d10..c1078b80aede252fd1c919da85feef39f20f2299 100644

--- a/third_party/WebKit/Source/core/html/forms/TextFieldInputType.cpp

+++ b/third_party/WebKit/Source/core/html/forms/TextFieldInputType.cpp

@@ -465,7 +465,7 @@ void TextFieldInputType::updatePlaceholderText()

placeholder->setAttribute(idAttr, ShadowElementNames::placeholder());

Element* container = containerElement();

Node* previous = container ? container : element().innerEditorElement();

- previous->parentNode()->insertBefore(placeholder, previous->nextSibling());

+ previous->parentNode()->insertBefore(placeholder, previous);

ASSERT_WITH_SECURITY_IMPLICATION(placeholder->parentNode() == previous->parentNode());

}

placeholder->setTextContent(placeholderText);