third_party/WebKit/Source/core/html/HTMLTextAreaElement.cpp - Issue 1478573002: Double-clicking whitespace after value text should select the last word in INPUT/TEXTAREA.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/HTMLTextAreaElement.cpp

Issue 1478573002: Double-clicking whitespace after value text should select the last word in INPUT/TEXTAREA. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/platform/mac/fast/forms/textarea-placeholder-visibility-2-expected.txt ('k') | third_party/WebKit/Source/core/html/forms/TextFieldInputType.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/html/HTMLTextAreaElement.cpp

diff --git a/third_party/WebKit/Source/core/html/HTMLTextAreaElement.cpp b/third_party/WebKit/Source/core/html/HTMLTextAreaElement.cpp

index 53ff7b69cc845cd49cd2d7d2d5ef6deb7c08785c..333d0a209a56bbcd539b611ad8419c5f54a486fc 100644

--- a/third_party/WebKit/Source/core/html/HTMLTextAreaElement.cpp

+++ b/third_party/WebKit/Source/core/html/HTMLTextAreaElement.cpp

@@ -628,7 +628,7 @@ void HTMLTextAreaElement::updatePlaceholderText()

placeholder->setShadowPseudoId(AtomicString("-webkit-input-placeholder", AtomicString::ConstructFromLiteral));

placeholder->setAttribute(idAttr, ShadowElementNames::placeholder());

placeholder->setInlineStyleProperty(CSSPropertyDisplay, isPlaceholderVisible() ? CSSValueBlock : CSSValueNone, true);

- userAgentShadowRoot()->insertBefore(placeholder, innerEditorElement()->nextSibling());

+ userAgentShadowRoot()->insertBefore(placeholder, innerEditorElement());

}

placeholder->setTextContent(placeholderText);

}