Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(294)

Issue 1478533002: Reland of Disable non-standard Promise functions in staging (Closed)

Created:
5 years ago by Dan Ehrenberg
Modified:
5 years ago
CC:
Michael Hablich, v8-reviews_googlegroups.com, adamk
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Reland of Disable non-standard Promise functions in staging (patchset #1 id:1 of https://codereview.chromium.org/1473603002/ ) Reason for revert: Breakage in Ignition seems unrelated; relanding. Original issue's description: > Revert of Disable non-standard Promise functions in staging (patchset #5 id:80001 of https://codereview.chromium.org/1469543003/ ) > > Reason for revert: > [Sheriff] This breaks ignition on arm sim debug: > https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20arm%20-%20sim%20-%20debug/builds/5317 > > Seems to not be caught by the cq bot that builds release with dchecks. > > Original issue's description: > > Disable non-standard Promise functions in staging > > > > This patch removes Promise functions and methods which are absent > > from the ES2015 specification when the --es-staging flag is on. > > > > BUG=v8:3237 > > R=rossberg > > LOG=Y > > > > Committed: https://crrev.com/941251af7e04d50ac2243da2870249a42111221a > > Cr-Commit-Position: refs/heads/master@{#32194} > > TBR=rossberg@chromium.org,littledan@chromium.org > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=v8:3237 > > Committed: https://crrev.com/86bd2b3c23b562213d5af158849dcd65f347a827 > Cr-Commit-Position: refs/heads/master@{#32199} TBR=rossberg@chromium.org,rmcilroy@chromium.org,machenbach@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:3237 Committed: https://crrev.com/9278b7b05a45c2089007e8b61822af96b5d0c8df Cr-Commit-Position: refs/heads/master@{#32235}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+77 lines, -24 lines) Patch
M BUILD.gn View 1 chunk +2 lines, -1 line 0 comments Download
M src/bootstrapper.cc View 5 chunks +6 lines, -0 lines 0 comments Download
M src/flag-definitions.h View 1 chunk +4 lines, -0 lines 0 comments Download
M src/js/prologue.js View 1 chunk +3 lines, -0 lines 0 comments Download
M src/js/promise.js View 3 chunks +10 lines, -4 lines 0 comments Download
A src/js/promise-extra.js View 1 chunk +30 lines, -0 lines 0 comments Download
M test/mjsunit/es6/debug-promises/reentry.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/es6/debug-promises/reject-after-resolve.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/es6/debug-promises/reject-caught-all.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/es6/debug-promises/reject-caught-late.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/es6/debug-promises/reject-caught-uncaught.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/es6/debug-promises/reject-uncaught-all.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/es6/debug-promises/reject-uncaught-uncaught.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/es6/debug-promises/reject-with-invalid-reject.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/es6/debug-promises/reject-with-throw-in-reject.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/es6/debug-promises/reject-with-undefined-reject.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/es6/debug-promises/throw-caught-all.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/es6/debug-promises/throw-caught-late.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/es6/debug-promises/throw-caught-uncaught.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/es6/debug-promises/throw-uncaught-all.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/es6/debug-promises/throw-uncaught-uncaught.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/es6/debug-promises/throw-with-throw-in-reject.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/es6/debug-promises/throw-with-undefined-reject.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/es6/promise-internal-setter.js View 1 chunk +2 lines, -0 lines 0 comments Download
M test/mjsunit/es6/promises.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/es6/regress/regress-cr372788.js View 1 chunk +1 line, -1 line 0 comments Download
M tools/gyp/v8.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Dan Ehrenberg
Created Reland of Disable non-standard Promise functions in staging
5 years ago (2015-11-24 23:17:25 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1478533002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1478533002/1
5 years ago (2015-11-24 23:17:41 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-11-24 23:17:59 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/9278b7b05a45c2089007e8b61822af96b5d0c8df Cr-Commit-Position: refs/heads/master@{#32235}
5 years ago (2015-11-24 23:18:36 UTC) #4
Michael Achenbach
Why unrelated? It still breaks: https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20arm%20-%20sim%20-%20debug/builds/5337 So it's somehow related. Please at least just switch ...
5 years ago (2015-11-25 07:48:50 UTC) #5
Michael Achenbach
On 2015/11/25 07:48:50, Michael Achenbach wrote: > Why unrelated? It still breaks: > https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20arm%20-%20sim%20-%20debug/builds/5337 > ...
5 years ago (2015-11-25 08:05:12 UTC) #6
Dan Ehrenberg
5 years ago (2015-12-02 20:34:41 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1493713004/ by littledan@chromium.org.

The reason for reverting is: Will test better; there seems to be a bug related
to this..

Powered by Google App Engine
This is Rietveld 408576698