Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(263)

Issue 1478493004: Aura Android: upstream platform_util* related files (Closed)

Created:
5 years ago by bshe
Modified:
5 years ago
Reviewers:
mfomitchev, sky
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Aura Android: upstream platform_util* related files BUG=561669 Committed: https://crrev.com/ece92328ce4f995a74f227b225b5424edc67b4c0 Cr-Commit-Position: refs/heads/master@{#363026}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -1 line) Patch
M chrome/browser/BUILD.gn View 1 1 chunk +7 lines, -0 lines 0 comments Download
M chrome/browser/platform_util.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/platform_util_aura.cc View 1 chunk +19 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 17 (7 generated)
bshe
Hi Mikhail. Do you mind to take a look at this CL? Thanks! Biao
5 years ago (2015-11-30 22:22:11 UTC) #2
mfomitchev
LGTM
5 years ago (2015-12-01 14:14:02 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1478493004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1478493004/1
5 years ago (2015-12-01 14:47:07 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/123528)
5 years ago (2015-12-01 14:56:44 UTC) #7
bshe
+sky for owners. Thanks!
5 years ago (2015-12-02 14:30:47 UTC) #9
sky
LGTM
5 years ago (2015-12-02 15:07:14 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1478493004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1478493004/20001
5 years ago (2015-12-03 16:35:10 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years ago (2015-12-03 18:57:32 UTC) #14
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/ece92328ce4f995a74f227b225b5424edc67b4c0 Cr-Commit-Position: refs/heads/master@{#363026}
5 years ago (2015-12-03 18:58:27 UTC) #16
David Trainor- moved to gerrit
5 years ago (2015-12-04 22:06:54 UTC) #17
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1498273002/ by dtrainor@chromium.org.

The reason for reverting is: Causing build breakage when combined with
https://codereview.chromium.org/1459793002..

Powered by Google App Engine
This is Rietveld 408576698