Issue 1478473002: Merge to XFA: Fix a NULL pointer crash in the CJBig2_Image copy constructor.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1478473002: Merge to XFA: Fix a NULL pointer crash in the CJBig2_Image copy constructor. (Closed)

Created:
5 years ago by Lei Zhang

Modified:
5 years ago

Reviewers:
Tom Sepez

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa

Target Ref:
refs/heads/xfa

Visibility:
Public.

Merge to XFA: Fix a NULL pointer crash in the CJBig2_Image copy constructor. Also change the copy ctor to take a const ref. BUG=560520 TBR=tsepez@chromium.org Review URL: https://codereview.chromium.org/1472113002 . (cherry picked from commit d03bc01003ae2603dafdc07b901ffef0a509a2b9) Committed: https://pdfium.googlesource.com/pdfium/+/b599f192d635d97a2f41e8ffc9784e5291b11caf

Created: 5 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+8 lines, -7 lines)			Patch
M	core/src/fxcodec/jbig2/JBig2_Image.h	View	3 chunks	+5 lines, -4 lines	0 comments	Download
M	core/src/fxcodec/jbig2/JBig2_Image.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	core/src/fxcodec/jbig2/JBig2_SddProc.cpp	View	2 chunks	+2 lines, -2 lines	0 comments	Download

Total messages: 3 (0 generated)

Lei Zhang

Committed patchset #1 (id:1) manually as b599f192d635d97a2f41e8ffc9784e5291b11caf (presubmit successful).

5 years ago (2015-11-24 19:47:31 UTC) #2

Message was sent while issue was closed.

lgtm