Issue 1472113002: Fix a NULL pointer crash in the CJBig2_Image copy constructor.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1472113002: Fix a NULL pointer crash in the CJBig2_Image copy constructor. (Closed)

Created:
5 years ago by Lei Zhang

Modified:
5 years ago

Reviewers:
Tom Sepez

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Fix a NULL pointer crash in the CJBig2_Image copy constructor. Also change the copy ctor to take a const ref. BUG=560520 R=tsepez@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/d03bc01003ae2603dafdc07b901ffef0a509a2b9

Patch Set 2 : rebase #

Created: 5 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+8 lines, -7 lines)			Patch
M	core/src/fxcodec/jbig2/JBig2_Image.h	View	3 chunks	+5 lines, -4 lines	0 comments	Download
M	core/src/fxcodec/jbig2/JBig2_Image.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	core/src/fxcodec/jbig2/JBig2_SddProc.cpp	View	2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Lei Zhang

https://codereview.chromium.org/1472113002/diff/1/core/src/fxcodec/jbig2/JBig2_SddProc.cpp File core/src/fxcodec/jbig2/JBig2_SddProc.cpp (right): https://codereview.chromium.org/1472113002/diff/1/core/src/fxcodec/jbig2/JBig2_SddProc.cpp#newcode269 core/src/fxcodec/jbig2/JBig2_SddProc.cpp:269: pDict->AddImage(SDINSYMS[I] ? new CJBig2_Image(*SDINSYMS[I]) : nullptr); These are consistent ...

5 years ago (2015-11-24 18:22:37 UTC) #2

Lei Zhang

5 years ago (2015-11-24 19:29:44 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
d03bc01003ae2603dafdc07b901ffef0a509a2b9 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Issue 1472113002: Fix a NULL pointer crash in the CJBig2_Image copy constructor. (Closed)

Description

Patch Set 1 #

Patch Set 2 : rebase #

Messages