libaddressinput - Don't make transient copies of entire JSON rule dictionaries

third_party/libaddressinput/chromium/cpp/src/util/json.h

Index: third_party/libaddressinput/chromium/cpp/src/util/json.h
diff --git a/third_party/libaddressinput/chromium/cpp/src/util/json.h b/third_party/libaddressinput/chromium/cpp/src/util/json.h
index 9af7f1cd0cbaddbf8d509d50ae0a27388675c1d4..7c55da397225eebd4bb0b4ce221005c3003a4cea 100644
--- a/third_party/libaddressinput/chromium/cpp/src/util/json.h
+++ b/third_party/libaddressinput/chromium/cpp/src/util/json.h
@@ -50,7 +50,8 @@ class Json {
   // Sets |value| to the dictionary for |key| if it exists and has a dictionary
   // value. Returns false if the key doesn't exist or doesn't correspond to a
   // dictionary. The JSON object must be parsed successfully in ParseObject()
-  // before invoking this method.
+  // before invoking this method. The returned object is only gauranteed to be

[Dan Beam, 2014/02/01 01:02:36]

nit: |value| is only guaranteed to be valid as long as |this| is valid.

[Evan Stade, 2014/02/01 01:11:12]

Done.

+  // valid as long as |this| is valid.
   virtual bool GetJsonValueForKey(const std::string& key,
                                   scoped_ptr<Json>* value) const = 0;