libaddressinput - Don't make transient copies of entire JSON rule dictionaries

third_party/libaddressinput/chromium/cpp/src/util/json.h

 // Copyright (C) 2013 Google Inc.
 //
 // Licensed under the Apache License, Version 2.0 (the "License");
 // you may not use this file except in compliance with the License.
 // You may obtain a copy of the License at
 //
 // http://www.apache.org/licenses/LICENSE-2.0
 //
 // Unless required by applicable law or agreed to in writing, software
 // distributed under the License is distributed on an "AS IS" BASIS,
@@ skipping 32 matching lines @@
   // Sets |value| to the string for |key| if it exists and has a string value.
   // Returns false if the key doesn't exist or doesn't correspond to a string.
   // The JSON object must be parsed successfully in ParseObject() before
   // invoking this method.
   virtual bool GetStringValueForKey(const std::string& key,
                                     std::string* value) const = 0;
 
   // Sets |value| to the dictionary for |key| if it exists and has a dictionary
   // value. Returns false if the key doesn't exist or doesn't correspond to a
   // dictionary. The JSON object must be parsed successfully in ParseObject()
-  // before invoking this method.
+  // before invoking this method. The returned object is only gauranteed to be

[Dan Beam, 2014/02/01 01:02:36]

nit: |value| is only guaranteed to be valid as long as |this| is valid.

[Evan Stade, 2014/02/01 01:11:12]

Done.

+  // valid as long as |this| is valid.
   virtual bool GetJsonValueForKey(const std::string& key,
                                   scoped_ptr<Json>* value) const = 0;
 
  protected:
   Json();
 };
 
 }  // namespace addressinput
 }  // namespace i18n
 
 #endif  // I18N_ADDRESSINPUT_UTIL_JSON_H_