runtime/vm/disassembler_arm.cc - Issue 14784011: Fixes for integer division on ARM hardware so that assembler tests pass.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/disassembler_arm.cc

Issue 14784011: Fixes for integer division on ARM hardware so that assembler tests pass. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/disassembler_arm.cc

===================================================================

--- runtime/vm/disassembler_arm.cc (revision 22334)

+++ runtime/vm/disassembler_arm.cc (working copy)

@@ -601,7 +601,7 @@

break;

}

case 7: {

- if (instr->Bits(21, 2) == 0x1) {

+ if ((instr->Bits(21, 2) == 0x1) && (instr->ConditionField() == AL)) {

Format(instr, "bkpt'cond #'imm12_4");

regis 2013/05/07 17:14:35 Remove 'cond.

zra 2013/05/07 17:50:18 Done.

} else {

// Format(instr, "smc'cond");

@@ -861,9 +861,9 @@

void ARMDecoder::DecodeType3(Instr* instr) {

if (instr->IsDivision()) {

if (instr->Bit(21)) {

- Format(instr, "udiv'cond 'rd, 'rn, 'rm");

+ Format(instr, "udiv'cond 'rn, 'rs, 'rm");

} else {

- Format(instr, "sdiv'cond 'rd, 'rn, 'rm");

+ Format(instr, "sdiv'cond 'rn, 'rs, 'rm");

}

return;

}

« runtime/vm/assembler_arm_test.cc ('K') | « runtime/vm/constants_arm.h ('k') | runtime/vm/simulator_arm.cc » ('j') | runtime/vm/simulator_arm.cc » ('J')