Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1285)

Unified Diff: runtime/vm/constants_arm.h

Issue 14784011: Fixes for integer division on ARM hardware so that assembler tests pass. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/constants_arm.h
===================================================================
--- runtime/vm/constants_arm.h (revision 22334)
+++ runtime/vm/constants_arm.h (working copy)
@@ -298,12 +298,20 @@
kOffset12Bits = 12,
kOffset12Mask = 0x00000fff,
- // Mul instruction register fields encodings.
+ // Mul instruction register field encodings.
kMulRdShift = 16,
kMulRdBits = 4,
kMulRnShift = 12,
kMulRnBits = 4,
+ // Div instruction register field encodings.
+ kDivRdShift = 16,
+ kDivRdBits = 4,
+ kDivRmShift = 8,
+ kDivRmBits = 4,
+ kDivRnShift = 0,
+ kDivRnBits = 4,
+
// MRC instruction offset field encoding.
kCRmShift = 0,
kCRmBits = 4,
@@ -449,6 +457,16 @@
return bit_cast<double, uint64_t>(imm64);
}
+ inline Register DivRdField() const {
+ return static_cast<Register>(Bits(kDivRdShift, kDivRdBits));
+ }
+ inline Register DivRmField() const {
+ return static_cast<Register>(Bits(kDivRmShift, kDivRmBits));
+ }
+ inline Register DivRnField() const {
+ return static_cast<Register>(Bits(kDivRnShift, kDivRnBits));
+ }
+
// Test for data processing instructions of type 0 or 1.
// See "ARM Architecture Reference Manual ARMv7-A and ARMv7-R edition",
// section A5.1 "ARM instruction set encoding".

Powered by Google App Engine
This is Rietveld 408576698