Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(278)

Issue 1478303002: Revert of [runtime] Replace global object link with native context link in all contexts. (Closed)

Created:
5 years ago by Michael Achenbach
Modified:
5 years ago
CC:
v8-reviews_googlegroups.com, Yang
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [runtime] Replace global object link with native context link in all contexts. (patchset #3 id:40001 of https://codereview.chromium.org/1480003002/ ) Reason for revert: [Sheriff] Breaks: https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20nosnap/builds/5472 Original issue's description: > [runtime] Replace global object link with native context link in all contexts. > > Previously all contexts had a link to the global object, but what is > required in most cases (except for the global load, store and delete > case) is the native context. > > This also removes the second dummy global object that was still linked > to every native context. We will add a different mechanism to ensure > that builtins do not pollute the actual global object during > bootstrapping. > > Drive-by-fix: Unify some MacroAssembler magic and drop obsolete stuff. > > R=yangguo@chromium.org > > Committed: https://crrev.com/d290f204938295bfecc5c8e645ccfcff6e80ddb8 > Cr-Commit-Position: refs/heads/master@{#32375} TBR=yangguo@chromium.org,mstarzinger@chromium.org,bmeurer@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/673108d0006693f8c36b47915e59315cdc997e72 Cr-Commit-Position: refs/heads/master@{#32377}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+955 lines, -492 lines) Patch
M src/arm/builtins-arm.cc View 4 chunks +23 lines, -7 lines 0 comments Download
M src/arm/code-stubs-arm.cc View 8 chunks +18 lines, -13 lines 0 comments Download
M src/arm/macro-assembler-arm.h View 4 chunks +12 lines, -12 lines 0 comments Download
M src/arm/macro-assembler-arm.cc View 5 chunks +50 lines, -8 lines 0 comments Download
M src/arm64/builtins-arm64.cc View 4 chunks +15 lines, -5 lines 0 comments Download
M src/arm64/code-stubs-arm64.cc View 6 chunks +19 lines, -10 lines 0 comments Download
M src/arm64/macro-assembler-arm64.h View 4 chunks +12 lines, -11 lines 0 comments Download
M src/arm64/macro-assembler-arm64.cc View 6 chunks +45 lines, -7 lines 0 comments Download
M src/bootstrapper.cc View 6 chunks +43 lines, -3 lines 0 comments Download
M src/code-stubs-hydrogen.cc View 1 chunk +7 lines, -6 lines 0 comments Download
M src/compiler.h View 1 chunk +11 lines, -10 lines 0 comments Download
M src/compiler/ast-graph-builder.cc View 1 chunk +5 lines, -4 lines 0 comments Download
M src/compiler/bytecode-graph-builder.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/compiler/bytecode-graph-builder.cc View 1 chunk +10 lines, -3 lines 0 comments Download
M src/compiler/js-call-reducer.cc View 2 chunks +8 lines, -4 lines 0 comments Download
M src/compiler/js-generic-lowering.cc View 3 chunks +17 lines, -18 lines 0 comments Download
M src/compiler/js-operator.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/compiler/js-operator.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/js-typed-lowering.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/js-typed-lowering.cc View 11 chunks +71 lines, -40 lines 0 comments Download
M src/compiler/opcodes.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/typer.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M src/compiler/verifier.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/contexts.h View 4 chunks +9 lines, -9 lines 0 comments Download
M src/contexts.cc View 3 chunks +18 lines, -14 lines 0 comments Download
M src/contexts-inl.h View 2 chunks +8 lines, -8 lines 0 comments Download
M src/crankshaft/arm/lithium-codegen-arm.cc View 4 chunks +6 lines, -5 lines 0 comments Download
M src/crankshaft/arm64/lithium-codegen-arm64.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/crankshaft/hydrogen.cc View 7 chunks +30 lines, -12 lines 0 comments Download
M src/crankshaft/ia32/lithium-codegen-ia32.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M src/crankshaft/mips/lithium-codegen-mips.cc View 4 chunks +6 lines, -5 lines 0 comments Download
M src/crankshaft/mips64/lithium-codegen-mips64.cc View 4 chunks +6 lines, -5 lines 0 comments Download
M src/crankshaft/x64/lithium-codegen-x64.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M src/factory.cc View 6 chunks +5 lines, -6 lines 0 comments Download
M src/full-codegen/arm/full-codegen-arm.cc View 15 chunks +29 lines, -21 lines 0 comments Download
M src/full-codegen/arm64/full-codegen-arm64.cc View 7 chunks +19 lines, -7 lines 0 comments Download
M src/full-codegen/ia32/full-codegen-ia32.cc View 7 chunks +12 lines, -14 lines 0 comments Download
M src/full-codegen/mips/full-codegen-mips.cc View 15 chunks +29 lines, -21 lines 0 comments Download
M src/full-codegen/mips64/full-codegen-mips64.cc View 15 chunks +29 lines, -21 lines 0 comments Download
M src/full-codegen/x64/full-codegen-x64.cc View 7 chunks +14 lines, -8 lines 0 comments Download
M src/gdb-jit.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/ia32/builtins-ia32.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/ia32/code-stubs-ia32.cc View 3 chunks +10 lines, -6 lines 0 comments Download
M src/ia32/macro-assembler-ia32.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/ia32/macro-assembler-ia32.cc View 5 chunks +16 lines, -8 lines 0 comments Download
M src/ic/arm/handler-compiler-arm.cc View 1 chunk +4 lines, -1 line 0 comments Download
M src/ic/arm64/handler-compiler-arm64.cc View 1 chunk +3 lines, -1 line 0 comments Download
M src/ic/ia32/handler-compiler-ia32.cc View 1 chunk +4 lines, -1 line 0 comments Download
M src/ic/mips/handler-compiler-mips.cc View 1 chunk +4 lines, -1 line 0 comments Download
M src/ic/mips64/handler-compiler-mips64.cc View 1 chunk +5 lines, -1 line 0 comments Download
M src/ic/x64/handler-compiler-x64.cc View 1 chunk +4 lines, -1 line 0 comments Download
M src/interpreter/bytecode-generator.cc View 1 chunk +1 line, -4 lines 0 comments Download
M src/interpreter/interpreter.cc View 3 chunks +4 lines, -7 lines 0 comments Download
M src/isolate-inl.h View 1 chunk +1 line, -1 line 0 comments Download
M src/mips/builtins-mips.cc View 3 chunks +19 lines, -4 lines 0 comments Download
M src/mips/code-stubs-mips.cc View 8 chunks +18 lines, -13 lines 0 comments Download
M src/mips/macro-assembler-mips.h View 4 chunks +12 lines, -12 lines 0 comments Download
M src/mips/macro-assembler-mips.cc View 5 chunks +46 lines, -7 lines 0 comments Download
M src/mips64/builtins-mips64.cc View 3 chunks +19 lines, -4 lines 0 comments Download
M src/mips64/code-stubs-mips64.cc View 8 chunks +18 lines, -13 lines 0 comments Download
M src/mips64/macro-assembler-mips64.h View 4 chunks +12 lines, -12 lines 0 comments Download
M src/mips64/macro-assembler-mips64.cc View 5 chunks +46 lines, -7 lines 0 comments Download
M src/profiler/heap-snapshot-generator.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/runtime/runtime-scopes.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/snapshot/serialize.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/snapshot/snapshot-common.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M src/x64/builtins-x64.cc View 5 chunks +6 lines, -6 lines 0 comments Download
M src/x64/code-stubs-x64.cc View 6 chunks +14 lines, -10 lines 0 comments Download
M src/x64/macro-assembler-x64.h View 4 chunks +8 lines, -12 lines 0 comments Download
M src/x64/macro-assembler-x64.cc View 4 chunks +35 lines, -7 lines 0 comments Download
M test/cctest/compiler/test-js-context-specialization.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M test/cctest/interpreter/test-bytecode-generator.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M test/cctest/test-heap.cc View 9 chunks +9 lines, -9 lines 0 comments Download
M test/unittests/compiler/js-typed-lowering-unittest.cc View 2 chunks +11 lines, -6 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Michael Achenbach
Created Revert of [runtime] Replace global object link with native context link in all contexts.
5 years ago (2015-11-27 14:29:15 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1478303002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1478303002/1
5 years ago (2015-11-27 14:29:33 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-11-27 14:30:17 UTC) #4
commit-bot: I haz the power
5 years ago (2015-11-27 14:30:31 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/673108d0006693f8c36b47915e59315cdc997e72
Cr-Commit-Position: refs/heads/master@{#32377}

Powered by Google App Engine
This is Rietveld 408576698