Issue 14783011: Merge 199372 "Make AppListController::InitView() act on the righ..."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14783011: Merge 199372 "Make AppListController::InitView() act on the righ..." (Closed)

Created:
7 years, 7 months ago by laforge

Modified:
7 years, 7 months ago

Reviewers:
koz (OOO until 15th September)

CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, tfarina

Base URL:
svn://svn.chromium.org/chrome/branches/1500/src/

Visibility:
Public.

More Reviews

Description

Merge 199372 "Make AppListController::InitView() act on the righ..." > Make AppListController::InitView() act on the right profile. > > It is currently using whatever profile is around at startup, which may be an > incognito window (and so get deleted at any time). This change initializes the > view with the app list's previous profile, and cancels itself if there's > a profile in the process of being shown already. > > This also separates the sending of UMA stats into its own deferred task. > > BUG=236487 > R=benwells@chromium.org > > Review URL: https://codereview.chromium.org/14587005 TBR=koz@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=199486

Patch Set 1 #

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+61 lines, -16 lines)			Patch
	M	chrome/browser/ui/app_list/app_list_service.cc	View		1 chunk	+2 lines, -0 lines	0 comments	Download
	M	chrome/browser/ui/views/app_list/app_list_controller_win.cc	View		6 chunks	+59 lines, -16 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Message was sent while issue was closed.

Committed patchset #1 manually as r199486.

Expand Messages | Collapse Messages