Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1083)

Issue 14587005: Make AppListController::InitView() act on the right profile. (Closed)

Created:
7 years, 7 months ago by koz (OOO until 15th September)
Modified:
7 years, 7 months ago
Reviewers:
benwells
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, tfarina, tapted
Visibility:
Public.

Description

Make AppListController::InitView() act on the right profile. It is currently using whatever profile is around at startup, which may be an incognito window (and so get deleted at any time). This change initializes the view with the app list's previous profile, and cancels itself if there's a profile in the process of being shown already. This also separates the sending of UMA stats into its own deferred task. BUG=236487 R=benwells@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=199372

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : work #

Patch Set 4 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -16 lines) Patch
M chrome/browser/ui/app_list/app_list_service.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/app_list/app_list_controller_win.cc View 1 2 6 chunks +59 lines, -16 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
koz (OOO until 15th September)
7 years, 7 months ago (2013-05-09 07:14:33 UTC) #1
benwells
lgtm. Nice change, I think you found a few other things while you were there ...
7 years, 7 months ago (2013-05-09 07:22:50 UTC) #2
koz (OOO until 15th September)
On 2013/05/09 07:22:50, benwells wrote: > lgtm. Nice change, I think you found a few ...
7 years, 7 months ago (2013-05-09 07:45:36 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/koz@chromium.org/14587005/4001
7 years, 7 months ago (2013-05-09 07:45:46 UTC) #4
commit-bot: I haz the power
Retried try job too often on ios_dbg_simulator for step(s) googleurl_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=ios_dbg_simulator&number=50877
7 years, 7 months ago (2013-05-09 08:07:37 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/koz@chromium.org/14587005/4001
7 years, 7 months ago (2013-05-09 21:40:31 UTC) #6
koz (OOO until 15th September)
7 years, 7 months ago (2013-05-10 04:38:29 UTC) #7
Message was sent while issue was closed.
Committed patchset #4 manually as r199372 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698