[Cast,Android,Presentation API] Split CastRouteController into session and media routes.

[Cast,Android,Presentation API] Split CastRouteController into session and media routes.

BUG=555075, 558484, 558565
MediaRoute is introduced that corresponds to a single connection between the
page and the Cast session. ClientRecord keeps Cast-specific info and
SessionRecord keeps track of connected routes and clients.

As a consequence, create/join/closeRoute were rewritten.

Committed: https://crrev.com/c180e6c9a0d4b0c2a6adcadedd45ee64e3b2f1a0
Cr-Commit-Position: refs/heads/master@{#362038}

[whywhat, 2015-11-26 19:16:01]

avayvod@chromium.org changed reviewers:
+ mlamouri@chromium.org

[whywhat, 2015-11-26 19:16:01]

PTaL

[mlamouri (slow - plz ping), 2015-11-27 14:23:39]

https://codereview.chromium.org/1478163002/diff/20001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/media/router/cast/CastMediaRouteProvider.java
(right):

https://codereview.chromium.org/1478163002/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/media/router/cast/CastMediaRouteProvider.java:87:
if (clientId != null && !mClientRecords.contains(clientId)) {
I'm not sure I understand how you can check if List<ClientRecord> contains a
String. Did I miss something?

https://codereview.chromium.org/1478163002/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/media/router/cast/CastMediaRouteProvider.java:296:
}
Do you tihnk you can have a method called "canJoinExistingSession()" ?

https://codereview.chromium.org/1478163002/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/media/router/cast/CastMediaRouteProvider.java:338:
for (int i = mClientRecords.size() - 1; i >= 0; --i) {
Maybe you can use a reverse iterator?

https://codereview.chromium.org/1478163002/diff/20001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/media/router/cast/CreateRouteRequest.java
(right):

https://codereview.chromium.org/1478163002/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/media/router/cast/CreateRouteRequest.java:32:
private static final String TAG = "cr_MediaRouter";
I have to say that I'm getting annoyed by that presubmit check. I've sent a CL
fixing chrome/:
https://codereview.chromium.org/1480023002

https://codereview.chromium.org/1478163002/diff/20001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/media/router/cast/SessionRecord.java
(right):

https://codereview.chromium.org/1478163002/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/media/router/cast/SessionRecord.java:17:
public List<String> clientIds = new ArrayList<String>();
Should they be unique? If yes, could they be a hash/set?

https://codereview.chromium.org/1478163002/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/media/router/cast/SessionRecord.java:22:
public List<String> routeIds = new ArrayList<String>();
ditto

[whywhat, 2015-11-27 19:44:39]

https://codereview.chromium.org/1478163002/diff/20001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/media/router/cast/CastMediaRouteProvider.java
(right):

https://codereview.chromium.org/1478163002/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/media/router/cast/CastMediaRouteProvider.java:87:
if (clientId != null && !mClientRecords.contains(clientId)) {
On 2015/11/27 at 14:23:39, Mounir Lamouri wrote:
> I'm not sure I understand how you can check if List<ClientRecord> contains a
String. Did I miss something?

Java for you... ¯\_(ツ)_/¯
Fixed.

https://codereview.chromium.org/1478163002/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/media/router/cast/CastMediaRouteProvider.java:296:
}
On 2015/11/27 at 14:23:39, Mounir Lamouri wrote:
> Do you tihnk you can have a method called "canJoinExistingSession()" ?

Done.

https://codereview.chromium.org/1478163002/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/media/router/cast/CastMediaRouteProvider.java:338:
for (int i = mClientRecords.size() - 1; i >= 0; --i) {
On 2015/11/27 at 14:23:39, Mounir Lamouri wrote:
> Maybe you can use a reverse iterator?

Is there such a thing in Java? Do you have an example?

https://codereview.chromium.org/1478163002/diff/20001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/media/router/cast/CreateRouteRequest.java
(right):

https://codereview.chromium.org/1478163002/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/media/router/cast/CreateRouteRequest.java:32:
private static final String TAG = "cr_MediaRouter";
On 2015/11/27 at 14:23:39, Mounir Lamouri wrote:
> I have to say that I'm getting annoyed by that presubmit check. I've sent a CL
fixing chrome/:
> https://codereview.chromium.org/1480023002

Cool. Ack.

https://codereview.chromium.org/1478163002/diff/20001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/media/router/cast/SessionRecord.java
(right):

https://codereview.chromium.org/1478163002/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/media/router/cast/SessionRecord.java:17:
public List<String> clientIds = new ArrayList<String>();
On 2015/11/27 at 14:23:39, Mounir Lamouri wrote:
> Should they be unique? If yes, could they be a hash/set?

Done.

https://codereview.chromium.org/1478163002/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/media/router/cast/SessionRecord.java:22:
public List<String> routeIds = new ArrayList<String>();
On 2015/11/27 at 14:23:39, Mounir Lamouri wrote:
> ditto

Done.

[whywhat, 2015-11-27 19:48:17]

Fixed comments

[mlamouri (slow - plz ping), 2015-11-27 20:10:44]

lgtm

https://codereview.chromium.org/1478163002/diff/40001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/media/router/cast/CastMediaRouteProvider.java
(right):

https://codereview.chromium.org/1478163002/diff/40001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/media/router/cast/CastMediaRouteProvider.java:306:
// TODO(avayvod): Implement ReceiverAction.STOP.
nit: link to https://crbug.com/561470 ?

[whywhat, 2015-11-27 21:06:41]

Added bug number

[whywhat, 2015-11-27 21:06:51]

https://codereview.chromium.org/1478163002/diff/40001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/media/router/cast/CastMediaRouteProvider.java
(right):

https://codereview.chromium.org/1478163002/diff/40001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/media/router/cast/CastMediaRouteProvider.java:306:
// TODO(avayvod): Implement ReceiverAction.STOP.
On 2015/11/27 at 20:10:44, Mounir Lamouri wrote:
> nit: link to https://crbug.com/561470 ?

done.

[whywhat, 2015-11-27 21:06:54]

The CQ bit was checked by avayvod@chromium.org

[whywhat, 2015-11-27 21:06:54]

The patchset sent to the CQ was uploaded after l-g-t-m from
mlamouri@chromium.org
Link to the patchset: https://codereview.chromium.org/1478163002/#ps60001
(title: "Added bug number")

[commit-bot: I haz the power, 2015-11-27 21:07:01]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1478163002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1478163002/60001

[commit-bot: I haz the power, 2015-11-27 21:22:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-27 21:22:41]

Try jobs failed on following builders:
  linux_android_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_android_r...)

[whywhat, 2015-11-27 21:43:27]

Changed ArraySet to HashSet

[whywhat, 2015-11-27 21:43:48]

The CQ bit was checked by avayvod@chromium.org

[whywhat, 2015-11-27 21:43:48]

The patchset sent to the CQ was uploaded after l-g-t-m from
mlamouri@chromium.org
Link to the patchset: https://codereview.chromium.org/1478163002/#ps80001
(title: "Changed ArraySet to HashSet")

[commit-bot: I haz the power, 2015-11-27 21:44:08]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1478163002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1478163002/80001

[commit-bot: I haz the power, 2015-11-27 22:23:21]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2015-11-27 22:23:40]

Failed to apply the patch.

[commit-bot: I haz the power, 2015-11-27 22:24:41]

Description was changed from

==========
[Cast,Android,Presentation API] Split CastRouteController into session and media
routes.

BUG=555075,558484,558565

MediaRoute is introduced that corresponds to a single connection between the
page and the Cast session. ClientRecord keeps Cast-specific info and
SessionRecord keeps track of connected routes and clients.

As a consequence, create/join/closeRoute were rewritten.
==========

to

==========
[Cast,Android,Presentation API] Split CastRouteController into session and media
routes.

BUG=555075,558484,558565

MediaRoute is introduced that corresponds to a single connection between the
page and the Cast session. ClientRecord keeps Cast-specific info and
SessionRecord keeps track of connected routes and clients.

As a consequence, create/join/closeRoute were rewritten.

Committed: https://crrev.com/c180e6c9a0d4b0c2a6adcadedd45ee64e3b2f1a0
Cr-Commit-Position: refs/heads/master@{#362038}
==========

[commit-bot: I haz the power, 2015-11-27 22:24:42]

Patchset 5 (id:??) landed as
https://crrev.com/c180e6c9a0d4b0c2a6adcadedd45ee64e3b2f1a0
Cr-Commit-Position: refs/heads/master@{#362038}