Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(507)

Issue 1480023002: Remove all "cr." and "cr_" prefixes from TAG from chrome/. (Closed)

Created:
5 years ago by mlamouri (slow - plz ping)
Modified:
5 years ago
CC:
asanka, chromium-reviews, feature-media-reviews_chromium.org, maxbogue+watch_chromium.org, mcasas+watch_chromium.org, media-router+watch_chromium.org, plaree+watch_chromium.org, posciak+watch_chromium.org, pvalenzuela+watch_chromium.org, tim+watch_chromium.org, zea+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove all "cr." and "cr_" prefixes from TAG from chrome/. There is a presubmit check on Android that checks if the TAG of a class is of form "cr.Foo". Any change to the file hits that check, confusing developers. Furthermore, Chrome now appends a prefix to Log TAGs so we should simply remove all prefixed. This batch change apply a simple `sed` script to all the java files in chrome/. This is using the following commands: find chrome/ -name "*.java" | xargs sed -ie "s:TAG = \"cr\.:TAG = \"cr_:g" find chrome/ -name "*.java" | xargs sed -ie "s:TAG = \"cr_:TAG = \":g" BUG=533072 Committed: https://crrev.com/4e79052feedd72fa03ed4d1f1b59b70b5d581b36 Cr-Commit-Position: refs/heads/master@{#362001}

Patch Set 1 #

Patch Set 2 : remove cr prefix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -39 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/BackgroundSyncLauncherService.java View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/ChromeLifetimeController.java View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/IntentHandler.java View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/customtabs/ActionButtonParams.java View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabsConnection.java View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/document/DocumentMigrationHelper.java View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/download/ChromeDownloadDelegate.java View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/download/DownloadManagerService.java View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarkEditActivity.java View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/externalauth/ExternalAuthUtils.java View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/feedback/ConnectivityChecker.java View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/feedback/ConnectivityTask.java View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/gcore/ChromeGoogleApiClientImpl.java View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/gcore/ConnectedTask.java View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/gsa/ContextReporter.java View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/historyreport/HistoryReportJniBridge.java View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/invalidation/ChromiumSyncAdapter.java View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/invalidation/DelayedInvalidationsController.java View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/media/MediaCaptureNotificationService.java View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/media/router/ChromeMediaRouter.java View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/media/router/cast/CastMediaRouteProvider.java View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/media/router/cast/CastRouteController.java View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/media/router/cast/CreateRouteRequest.java View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaNotificationManager.java View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaSessionTabHelper.java View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/omaha/ExponentialBackoffScheduler.java View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/omaha/OmahaClient.java View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/printing/TabPrinter.java View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/signin/SigninManager.java View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/snackbar/SnackbarManager.java View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/sync/SyncController.java View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/tabmodel/document/StorageDelegate.java View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/util/IntentUtils.java View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/util/PlatformUtil.java View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappLauncherActivity.java View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/document/DocumentModeTestBase.java View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/sync_shell/javatests/src/org/chromium/chrome/browser/sync/FakeServerHelper.java View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (5 generated)
mlamouri (slow - plz ping)
dgn@, can you have a look at this. I believe you wrote the presubmit check. ...
5 years ago (2015-11-27 13:57:12 UTC) #2
dgn
The output is cr_Foo, but if you have your tag is "Foo", we will prepend ...
5 years ago (2015-11-27 14:01:31 UTC) #3
mlamouri (slow - plz ping)
Ok. I will chaneg cr_ and cr. to {}.
5 years ago (2015-11-27 14:03:47 UTC) #5
mlamouri (slow - plz ping)
PTAL
5 years ago (2015-11-27 14:08:09 UTC) #7
dgn
lgtm
5 years ago (2015-11-27 14:09:54 UTC) #8
jochen (gone - plz use gerrit)
lgtm
5 years ago (2015-11-27 14:25:40 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1480023002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1480023002/20001
5 years ago (2015-11-27 14:26:55 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years ago (2015-11-27 14:51:56 UTC) #12
commit-bot: I haz the power
5 years ago (2015-11-27 14:52:44 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/4e79052feedd72fa03ed4d1f1b59b70b5d581b36
Cr-Commit-Position: refs/heads/master@{#362001}

Powered by Google App Engine
This is Rietveld 408576698