content/browser/service_worker/service_worker_url_request_job_unittest.cc - Issue 1478103002: [WIP] [service worker] Fix detach controller and fallback to network mechanism

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/service_worker_url_request_job_unittest.cc

Issue 1478103002: [WIP] [service worker] Fix detach controller and fallback to network mechanism (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/frame_host/navigation_handle_impl.cc ('K') | « content/browser/service_worker/service_worker_url_request_job.cc ('k') | content/child/service_worker/service_worker_dispatcher.cc » ('j') | third_party/WebKit/Source/core/fetch/ResourceLoader.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/service_worker/service_worker_url_request_job_unittest.cc

diff --git a/content/browser/service_worker/service_worker_url_request_job_unittest.cc b/content/browser/service_worker/service_worker_url_request_job_unittest.cc

index 938b580719d575e2295a524d90ce643050179e06..a3d8118d0e0ee7ade0e2fe15b00ce894eac6326b 100644

--- a/content/browser/service_worker/service_worker_url_request_job_unittest.cc

+++ b/content/browser/service_worker/service_worker_url_request_job_unittest.cc

@@ -643,10 +643,11 @@ TEST_F(ServiceWorkerURLRequestJobTest, FailFetchDispatch) {

base::RunLoop().RunUntilIdle();

EXPECT_TRUE(request_->status().is_success());

- // We should have fallen back to network.

- EXPECT_EQ(200, request_->GetResponseCode());

- EXPECT_EQ("PASS", url_request_delegate_.response_data());

+ // The job returns 400 and signals that the request must be restarted.

+ EXPECT_EQ(400, request_->GetResponseCode());

+ EXPECT_EQ("", url_request_delegate_.response_data());

EXPECT_FALSE(HasInflightRequests());

ServiceWorkerProviderHost* host =

helper_->context()->GetProviderHost(kProcessID, kProviderID);

ASSERT_TRUE(host);