content/browser/frame_host/navigation_handle_impl.cc - Issue 1478103002: [WIP] [service worker] Fix detach controller and fallback to network mechanism

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/frame_host/navigation_handle_impl.cc

Issue 1478103002: [WIP] [service worker] Fix detach controller and fallback to network mechanism (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | content/browser/service_worker/service_worker_url_request_job.cc » ('j') | third_party/WebKit/Source/core/fetch/ResourceLoader.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/frame_host/navigation_handle_impl.cc

diff --git a/content/browser/frame_host/navigation_handle_impl.cc b/content/browser/frame_host/navigation_handle_impl.cc

index 4fcb2c6c64bea036e556a0576ab29ad57f826ed3..6a2dea4a6379ed55e43af35ab9890657dd9adbcf 100644

--- a/content/browser/frame_host/navigation_handle_impl.cc

+++ b/content/browser/frame_host/navigation_handle_impl.cc

@@ -306,7 +306,7 @@ void NavigationHandleImpl::DidRedirectNavigation(const GURL& new_url) {

void NavigationHandleImpl::ReadyToCommitNavigation(

RenderFrameHostImpl* render_frame_host,

scoped_refptr<net::HttpResponseHeaders> response_headers) {

- DCHECK(!render_frame_host_);

+ // DCHECK(!render_frame_host_);

falken 2015/11/26 10:36:42 clamy: How bad is disabling this DCHECK?

render_frame_host_ = render_frame_host;

response_headers_ = response_headers;

state_ = READY_TO_COMMIT;

« no previous file with comments | « no previous file | content/browser/service_worker/service_worker_url_request_job.cc » ('j') | third_party/WebKit/Source/core/fetch/ResourceLoader.cpp » ('J')