[WIP] [service worker] Fix detach controller and fallback to network mechanism

content/browser/frame_host/navigation_handle_impl.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/frame_host/navigation_handle_impl.h"
 
 #include "base/command_line.h"
 #include "content/browser/frame_host/frame_tree_node.h"
 #include "content/browser/frame_host/navigator.h"
 #include "content/browser/frame_host/navigator_delegate.h"
@@ skipping 288 matching lines @@
 }
 
 void NavigationHandleImpl::DidRedirectNavigation(const GURL& new_url) {
   url_ = new_url;
   GetDelegate()->DidRedirectNavigation(this);
 }
 
 void NavigationHandleImpl::ReadyToCommitNavigation(
     RenderFrameHostImpl* render_frame_host,
     scoped_refptr<net::HttpResponseHeaders> response_headers) {
-  DCHECK(!render_frame_host_);
+  // DCHECK(!render_frame_host_);

[falken, 2015/11/26 10:36:42]

clamy: How bad is disabling this DCHECK?

   render_frame_host_ = render_frame_host;
   response_headers_ = response_headers;
   state_ = READY_TO_COMMIT;
 
   // Only notify the WebContentsObservers when PlzNavigate is enabled, as
   // |render_frame_host_| may be wrong in the case of transfer navigations.
   if (base::CommandLine::ForCurrentProcess()->HasSwitch(
           switches::kEnableBrowserSideNavigation)) {
     GetDelegate()->ReadyToCommitNavigation(this);
   }
@@ skipping 73 matching lines @@
 void NavigationHandleImpl::RunCompleteCallback(
     NavigationThrottle::ThrottleCheckResult result) {
   DCHECK(result != NavigationThrottle::DEFER);
   if (!complete_callback_.is_null())
     complete_callback_.Run(result);
 
   complete_callback_.Reset();
 }
 
 }  // namespace content