chrome/browser/resources/settings/on_startup_page/on_startup_page.html - Issue 1477773003: Use dom-if to hide settings pages and show explicitly.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/on_startup_page/on_startup_page.html

Issue 1477773003: Use dom-if to hide settings pages and show explicitly. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: . Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/resources/settings/basic_page/basic_page.html ('K') | « chrome/browser/resources/settings/compiled_resources.gyp ('k') | chrome/browser/resources/settings/settings_page/compiled_resources.gyp » ('j') | chrome/browser/resources/settings/settings_page/compiled_resources.gyp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/settings/on_startup_page/on_startup_page.html

diff --git a/chrome/browser/resources/settings/on_startup_page/on_startup_page.html b/chrome/browser/resources/settings/on_startup_page/on_startup_page.html

index 53d082c627c81d7a108e4a1c4e8355e34e44a12f..8c3969cfbec8bc792817b9ee8ae87caccf533b70 100644

--- a/chrome/browser/resources/settings/on_startup_page/on_startup_page.html

+++ b/chrome/browser/resources/settings/on_startup_page/on_startup_page.html

@@ -13,7 +13,7 @@

<settings-animated-pages id="pages" current-route="{{currentRoute}}"

- section="on-startup">

+ section="onStartup">

Dan Beam 2015/12/08 02:55:27 please try to stop writing these: https://en.wikip

stevenjb 2015/12/08 20:07:37 https://codereview.chromium.org/1505113005

<neon-animatable id="main">