Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(302)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1505113005: Rename SettingsOnStartupPage section to onStartup (Closed)

Created:
5 years ago by stevenjb
Modified:
5 years ago
Reviewers:
Dan Beam
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename SettingsOnStartupPage section to onStartup BUG=567765 Committed: https://crrev.com/f222874c368cbc85407d8f775914210ec110ab7a Cr-Commit-Position: refs/heads/master@{#363944}

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M chrome/browser/resources/settings/basic_page/basic_page.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/settings/settings_page/settings_router.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/data/webui/settings/main_page_browsertest.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
stevenjb
Just the onStartup rename.
5 years ago (2015-12-08 17:12:43 UTC) #2
Dan Beam
lgtm
5 years ago (2015-12-09 00:35:14 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1505113005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1505113005/20001
5 years ago (2015-12-09 00:46:25 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years ago (2015-12-09 02:44:22 UTC) #6
commit-bot: I haz the power
5 years ago (2015-12-09 02:45:25 UTC) #8
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/f222874c368cbc85407d8f775914210ec110ab7a
Cr-Commit-Position: refs/heads/master@{#363944}

Powered by Google App Engine
This is Rietveld 408576698