mojo/public/tools/bindings/generators/cpp_templates/interface_definition.tmpl - Issue 1477643002: Remove the TYPE_WITH_MOVE_CONSTRUCTOR_FOR_CPP_03 macro.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/public/tools/bindings/generators/cpp_templates/interface_definition.tmpl

Issue 1477643002: Remove the TYPE_WITH_MOVE_CONSTRUCTOR_FOR_CPP_03 macro. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@basepass

Patch Set: type-with-move: no-media Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: mojo/public/tools/bindings/generators/cpp_templates/interface_definition.tmpl

diff --git a/mojo/public/tools/bindings/generators/cpp_templates/interface_definition.tmpl b/mojo/public/tools/bindings/generators/cpp_templates/interface_definition.tmpl

index 267872a90e74512a12ac86e263031dfd09a1c743..9889f8b8bcd0cd274306538a0d8fa5a3365c27e5 100644

--- a/mojo/public/tools/bindings/generators/cpp_templates/interface_definition.tmpl

+++ b/mojo/public/tools/bindings/generators/cpp_templates/interface_definition.tmpl

@@ -16,7 +16,7 @@

{%- macro pass_params(parameters) %}

{%- for param in parameters %}

{%- if param.kind|is_move_only_kind -%}

-p_{{param.name}}.Pass()

+std::move(p_{{param.name}})

{%- else -%}

p_{{param.name}}

{%- endif -%}

@@ -56,7 +56,7 @@ class {{class_name}}_{{method.name}}_ForwardToCallback

{{class_name}}_{{method.name}}_ForwardToCallback(

const {{class_name}}::{{method.name}}Callback& callback,

scoped_refptr<mojo::internal::MultiplexRouter> router)

- : callback_(callback), serialization_context_(router.Pass()) {

+ : callback_(callback), serialization_context_(std::move(router)) {

}

bool Accept(mojo::Message* message) override;

private:

« no previous file with comments | « mojo/public/cpp/bindings/lib/scoped_interface_endpoint_handle.cc ('k') | net/cert/ct_log_verifier_unittest.cc » ('j') | no next file with comments »