Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(250)

Unified Diff: Source/bindings/v8/custom/V8CustomElementConstructorCustom.cpp

Issue 14776002: Create wrappers for unresolved Custom Elements at the correct type (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/v8/custom/V8CustomElementConstructorCustom.cpp
diff --git a/Source/bindings/v8/custom/V8CustomElementConstructorCustom.cpp b/Source/bindings/v8/custom/V8CustomElementConstructorCustom.cpp
index b693b6cb6cc99b11c17b63d9a863ea8ae1d788d6..cf0ebadd4d5a038b847dc4e2b7674fad8167985e 100644
--- a/Source/bindings/v8/custom/V8CustomElementConstructorCustom.cpp
+++ b/Source/bindings/v8/custom/V8CustomElementConstructorCustom.cpp
@@ -32,6 +32,7 @@
#include "V8CustomElementConstructor.h"
+#include "V8Element.h"
#include "bindings/v8/CustomElementHelpers.h"
#include "bindings/v8/V8Binding.h"
#include "core/dom/CustomElementConstructor.h"
@@ -53,7 +54,7 @@ v8::Handle<v8::Value> V8CustomElementConstructor::callAsFunctionCallback(const v
return v8Undefined();
}
// FIXME: is args.Holder() the right creation context?
- return CustomElementHelpers::wrap(element.get(), args.Holder(), args.GetIsolate());
+ return toV8(element.get(), args.Holder(), args.GetIsolate());
haraken 2013/05/01 18:49:12 What is this change for? I think the change looks
dominicc (has gone to gerrit) 2013/05/02 01:29:56 I want to simplify this so that it doesn't have in
}
} // namespace WebCore

Powered by Google App Engine
This is Rietveld 408576698