Create wrappers for unresolved Custom Elements at the correct type

Source/bindings/v8/custom/V8CustomElementConstructorCustom.cpp

 /*
 * Copyright (C) 2012 Google Inc. All rights reserved.
 * 
 * Redistribution and use in source and binary forms, with or without
 * modification, are permitted provided that the following conditions are
 * met:
 * 
 *     * Redistributions of source code must retain the above copyright
 * notice, this list of conditions and the following disclaimer.
 *     * Redistributions in binary form must reproduce the above
@@ skipping 14 matching lines @@
 * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
 * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 */
 
 #include "config.h"
 
 #include "V8CustomElementConstructor.h"
 
+#include "V8Element.h"
 #include "bindings/v8/CustomElementHelpers.h"
 #include "bindings/v8/V8Binding.h"
 #include "core/dom/CustomElementConstructor.h"
 
 namespace WebCore {
 
 v8::Handle<v8::Value> V8CustomElementConstructor::callAsFunctionCallback(const v8::Arguments& args)
 {
     if (!args.IsConstructCall())
         return throwTypeError("DOM object constructor cannot be called as a function.", args.GetIsolate());
     if (ConstructorMode::current() == ConstructorMode::WrapExistingObject)
         return args.Holder();
 
     CustomElementConstructor* impl = toNative(args.Holder());
     ExceptionCode ec = 0;
     RefPtr<Element> element = impl->createElement(ec);
     if (ec) {
         setDOMException(ec, args.GetIsolate());
         return v8Undefined();
     }
     // FIXME: is args.Holder() the right creation context?
-    return CustomElementHelpers::wrap(element.get(), args.Holder(), args.GetIsolate());
+    return toV8(element.get(), args.Holder(), args.GetIsolate());

[haraken, 2013/05/01 18:49:12]

What is this change for? I think the change looks correct in this case, but I'm
concerned about this kind of change because toV8() might be unexpectedly
overridden.

If you're sure that args.Holder() is a correct creation context, you should use
toV8Fast() instead of toV8().

If you're not sure, you can remove the FIXME and use toV8(element.get(),
v8::Handle<v8::Object>(), args.GetIsolate()).

[dominicc (has gone to gerrit), 2013/05/02 01:29:56]

I want to simplify this so that it doesn't have intimate knowledge of how custom
element wrapping works. I basically want to be the equivalent of
"createElement".
My hope is that there is nothing special about elements created by calling a
constructor with "new", doing createElement, or setting innerHTML and doing
querySelector. Since the toV8 wrapping machinery has to work in those cases, it
should work here too.
I stared at this more and I *think* args.Holder() is right. Is there a design
doc explaining the right way to use creation contexts?

 }
 
 } // namespace WebCore