Chromium Code Reviews| Index: fpdfsdk/src/jsapi/fxjs_v8_embeddertest.cpp |
| diff --git a/fpdfsdk/src/jsapi/fxjs_v8_embeddertest.cpp b/fpdfsdk/src/jsapi/fxjs_v8_embeddertest.cpp |
| index 8e685c9bd473223a3a093e761931cc3b604ecdf7..e7f50e1b94f8a6283e66f8001b838636a32cb078 100644 |
| --- a/fpdfsdk/src/jsapi/fxjs_v8_embeddertest.cpp |
| +++ b/fpdfsdk/src/jsapi/fxjs_v8_embeddertest.cpp |
| @@ -30,7 +30,9 @@ class FXJSV8Embeddertest : public EmbedderTest { |
| EmbedderTest::SetUp(); |
| v8::Isolate::Scope isolate_scope(m_pIsolate); |
| +#ifdef PDF_ENABLE_XFA |
| v8::Locker locker(m_pIsolate); |
|
Lei Zhang
2015/11/25 00:34:31
Do you know if these are needed on master too? Dit
Tom Sepez
2015/11/25 21:45:30
They are probably not needed anywhere. If you loo
|
| +#endif |
| v8::HandleScope handle_scope(m_pIsolate); |
| FXJS_PerIsolateData::SetUp(m_pIsolate); |
| FXJS_InitializeRuntime(m_pIsolate, nullptr, &m_pPersistentContext, |
| @@ -58,7 +60,9 @@ class FXJSV8Embeddertest : public EmbedderTest { |
| TEST_F(FXJSV8Embeddertest, Getters) { |
| v8::Isolate::Scope isolate_scope(isolate()); |
| +#ifdef PDF_ENABLE_XFA |
| v8::Locker locker(isolate()); |
| +#endif |
| v8::HandleScope handle_scope(isolate()); |
| v8::Context::Scope context_scope(GetV8Context()); |