Inflict PDF_ENABLE_XFA ifdefs on XFA fpdfsdk/

fpdfsdk/src/jsapi/fxjs_v8_embeddertest.cpp

 // Copyright 2015 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "core/include/fpdfapi/fpdf_parser.h"
 #include "fpdfsdk/include/jsapi/fxjs_v8.h"
 #include "testing/embedder_test.h"
 #include "testing/gtest/include/gtest/gtest.h"
 #include "third_party/base/nonstd_unique_ptr.h"
 
@@ skipping 12 matching lines @@
     m_pIsolate = v8::Isolate::New(params);
   }
 
   ~FXJSV8Embeddertest() override { m_pIsolate->Dispose(); }
 
   void SetUp() override {
     EmbedderTest::SetExternalIsolate(m_pIsolate);
     EmbedderTest::SetUp();
 
     v8::Isolate::Scope isolate_scope(m_pIsolate);
+#ifdef PDF_ENABLE_XFA
     v8::Locker locker(m_pIsolate);

[Lei Zhang, 2015/11/25 00:34:31]

Do you know if these are needed on master too? Ditto in other JS files.

[Tom Sepez, 2015/11/25 21:45:30]

They are probably not needed anywhere.  If you look, XFA has a threads package
API (that does nothing).  So maybe some other variant of XFA had threads.  We
don't.  I was going to let them be until the threads pacakge code was removed.

+#endif
     v8::HandleScope handle_scope(m_pIsolate);
     FXJS_PerIsolateData::SetUp(m_pIsolate);
     FXJS_InitializeRuntime(m_pIsolate, nullptr, &m_pPersistentContext,
                            &m_StaticObjects);
   }
 
   void TearDown() override {
     FXJS_ReleaseRuntime(m_pIsolate, &m_pPersistentContext, &m_StaticObjects);
     m_pPersistentContext.Reset();
     FXJS_Release();
     EmbedderTest::TearDown();
   }
 
   v8::Isolate* isolate() { return m_pIsolate; }
   v8::Local<v8::Context> GetV8Context() {
     return m_pPersistentContext.Get(m_pIsolate);
   }
 
  private:
   nonstd::unique_ptr<FXJS_ArrayBufferAllocator> m_pArrayBufferAllocator;
   v8::Isolate* m_pIsolate;
   v8::Global<v8::Context> m_pPersistentContext;
   std::vector<v8::Global<v8::Object>*> m_StaticObjects;
 };
 
 TEST_F(FXJSV8Embeddertest, Getters) {
   v8::Isolate::Scope isolate_scope(isolate());
+#ifdef PDF_ENABLE_XFA
   v8::Locker locker(isolate());
+#endif
   v8::HandleScope handle_scope(isolate());
   v8::Context::Scope context_scope(GetV8Context());
 
   FXJSErr error;
   int sts = FXJS_Execute(isolate(), nullptr, kScript, &error);
   EXPECT_EQ(0, sts);
 
   v8::Local<v8::Object> This = FXJS_GetThisObj(isolate());
   v8::Local<v8::Value> fred = FXJS_GetObjectElement(isolate(), This, L"fred");
   EXPECT_TRUE(fred->IsNumber());
 }