Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 1477383002: Use ContextUtils instead of ApplicationStatus for context. (Closed)

Created:
5 years ago by Torne
Modified:
4 years, 4 months ago
CC:
chromium-reviews, vmpstr+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use ContextUtils instead of ApplicationStatus for context. ApplicationStatus.getApplicationContext() is not defined for WebView, and ApplicationStatus is going to move to chrome/ in future. Use ContextUtils to get a global application context in layers below chrome instead, which works for all embedders. BUG=470582

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -8 lines) Patch
M base/android/java/src/org/chromium/base/SysUtils.java View 1 chunk +2 lines, -4 lines 0 comments Download
M components/signin/core/browser/android/java/src/org/chromium/components/signin/ChildAccountInfoFetcher.java View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/android/java/src/org/chromium/ui/base/LocalizationUtils.java View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
Torne
rogerta: components/signin OWNERS newt: ui/android OWNERS and also general review
5 years ago (2015-11-27 12:27:58 UTC) #2
Torne
5 years ago (2015-11-27 12:28:05 UTC) #3
newt (away)
lgtm
5 years ago (2015-11-30 17:38:07 UTC) #4
Roger Tawa OOO till Jul 10th
lgtm
5 years ago (2015-12-02 20:35:58 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1477383002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1477383002/1
5 years ago (2015-12-03 11:56:17 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_android_rel_ng/builds/104648)
5 years ago (2015-12-03 15:58:13 UTC) #9
Torne
Ugh, sysutils gets called before JNI is initialised :/ That makes initialising the context properly ...
5 years ago (2015-12-04 11:47:50 UTC) #10
Torne
4 years, 4 months ago (2016-07-28 13:18:34 UTC) #13
obsolete; the migration to ContextUtils already got done elsewhere.

Powered by Google App Engine
This is Rietveld 408576698