Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(949)

Unified Diff: components/scheduler/renderer/web_view_scheduler_impl.cc

Issue 1477353002: Revert of Move throttling of background timers into the renderer scheduler (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/scheduler/renderer/web_view_scheduler_impl.cc
diff --git a/components/scheduler/renderer/web_view_scheduler_impl.cc b/components/scheduler/renderer/web_view_scheduler_impl.cc
index 658fdbbe8a9aa96432ee3d6150c9c3bebd2acaff..28bc2163e10c4aa418a4cb0f6057bc3a76afc208 100644
--- a/components/scheduler/renderer/web_view_scheduler_impl.cc
+++ b/components/scheduler/renderer/web_view_scheduler_impl.cc
@@ -5,9 +5,6 @@
#include "components/scheduler/renderer/web_view_scheduler_impl.h"
#include "base/logging.h"
-#include "components/scheduler/base/virtual_time_domain.h"
-#include "components/scheduler/child/scheduler_tqm_delegate.h"
-#include "components/scheduler/renderer/renderer_scheduler_impl.h"
#include "components/scheduler/renderer/web_frame_scheduler_impl.h"
#include "third_party/WebKit/public/platform/WebFrameScheduler.h"
@@ -18,7 +15,7 @@
RendererSchedulerImpl* renderer_scheduler)
: web_view_(web_view),
renderer_scheduler_(renderer_scheduler),
- page_in_background_(false) {}
+ background_(false) {}
WebViewSchedulerImpl::~WebViewSchedulerImpl() {
// TODO(alexclarke): Find out why we can't rely on the web view outliving the
@@ -28,29 +25,17 @@
}
}
-void WebViewSchedulerImpl::setPageInBackground(bool page_in_background) {
- if (page_in_background_ == page_in_background)
- return;
-
- page_in_background_ = page_in_background;
-
- for (WebFrameSchedulerImpl* frame_scheduler : frame_schedulers_) {
- frame_scheduler->SetPageInBackground(page_in_background_);
- }
-}
-
-scoped_ptr<WebFrameSchedulerImpl>
-WebViewSchedulerImpl::createWebFrameSchedulerImpl() {
- scoped_ptr<WebFrameSchedulerImpl> frame_scheduler(
- new WebFrameSchedulerImpl(renderer_scheduler_, this));
- frame_scheduler->SetPageInBackground(page_in_background_);
- frame_schedulers_.insert(frame_scheduler.get());
- return frame_scheduler.Pass();
+void WebViewSchedulerImpl::setPageInBackground(bool background) {
+ background_ = background;
+ // TODO(alexclarke): Do something with this flag.
}
blink::WebPassOwnPtr<blink::WebFrameScheduler>
WebViewSchedulerImpl::createFrameScheduler() {
- return blink::adoptWebPtr(createWebFrameSchedulerImpl().release());
+ scoped_ptr<WebFrameSchedulerImpl> frame_scheduler(
+ new WebFrameSchedulerImpl(renderer_scheduler_, this));
+ frame_schedulers_.insert(frame_scheduler.get());
+ return blink::adoptWebPtr(frame_scheduler.release());
}
void WebViewSchedulerImpl::Unregister(WebFrameSchedulerImpl* frame_scheduler) {

Powered by Google App Engine
This is Rietveld 408576698