Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(244)

Side by Side Diff: components/scheduler/base/time_domain.cc

Issue 1477353002: Revert of Move throttling of background timers into the renderer scheduler (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/scheduler/base/time_domain.h" 5 #include "components/scheduler/base/time_domain.h"
6 6
7 #include <set> 7 #include <set>
8 8
9 #include "components/scheduler/base/task_queue_impl.h" 9 #include "components/scheduler/base/task_queue_impl.h"
10 #include "components/scheduler/base/task_queue_manager_delegate.h" 10 #include "components/scheduler/base/task_queue_manager_delegate.h"
11 #include "components/scheduler/scheduler_export.h" 11 #include "components/scheduler/scheduler_export.h"
12 12
13 namespace scheduler { 13 namespace scheduler {
14 14
15 TimeDomain::TimeDomain(Observer* observer) : observer_(observer) {} 15 TimeDomain::TimeDomain() {}
16 16
17 TimeDomain::~TimeDomain() { 17 TimeDomain::~TimeDomain() {}
18 for (internal::TaskQueueImpl* queue : registered_task_queues_) {
19 queue->SetTimeDomain(nullptr);
20 }
21 }
22
23 void TimeDomain::RegisterQueue(internal::TaskQueueImpl* queue) {
24 registered_task_queues_.insert(queue);
25 }
26 18
27 void TimeDomain::UnregisterQueue(internal::TaskQueueImpl* queue) { 19 void TimeDomain::UnregisterQueue(internal::TaskQueueImpl* queue) {
28 registered_task_queues_.erase(queue);
29
30 // We need to remove |task_queue| from delayed_wakeup_multimap_ which is a 20 // We need to remove |task_queue| from delayed_wakeup_multimap_ which is a
31 // little awkward since it's keyed by time. O(n) running time. 21 // little awkward since it's keyed by time. O(n) running time.
32 for (DelayedWakeupMultimap::iterator iter = delayed_wakeup_multimap_.begin(); 22 for (DelayedWakeupMultimap::iterator iter = delayed_wakeup_multimap_.begin();
33 iter != delayed_wakeup_multimap_.end();) { 23 iter != delayed_wakeup_multimap_.end();) {
34 if (iter->second == queue) { 24 if (iter->second == queue) {
35 DelayedWakeupMultimap::iterator temp = iter; 25 DelayedWakeupMultimap::iterator temp = iter;
36 iter++; 26 iter++;
37 // O(1) amortized. 27 // O(1) amortized.
38 delayed_wakeup_multimap_.erase(temp); 28 delayed_wakeup_multimap_.erase(temp);
39 } else { 29 } else {
40 iter++; 30 iter++;
41 } 31 }
42 } 32 }
43 33
44 // |newly_updatable_| might contain |queue|, we use 34 // |newly_updatable_| might contain |queue|, we use
45 // MoveNewlyUpdatableQueuesIntoUpdatableQueueSet to flush it out. 35 // MoveNewlyUpdatableQueuesIntoUpdatableQueueSet to flush it out.
46 MoveNewlyUpdatableQueuesIntoUpdatableQueueSet(); 36 MoveNewlyUpdatableQueuesIntoUpdatableQueueSet();
47 updatable_queue_set_.erase(queue); 37 updatable_queue_set_.erase(queue);
48 } 38 }
49 39
50 void TimeDomain::MigrateQueue(internal::TaskQueueImpl* queue, 40 void TimeDomain::MigrateQueue(internal::TaskQueueImpl* queue,
51 TimeDomain* destination_time_domain) { 41 TimeDomain* destination_time_domain) {
52 DCHECK(destination_time_domain);
53 registered_task_queues_.erase(queue);
54
55 LazyNow destination_lazy_now = destination_time_domain->CreateLazyNow(); 42 LazyNow destination_lazy_now = destination_time_domain->CreateLazyNow();
56 // We need to remove |task_queue| from delayed_wakeup_multimap_ which is a 43 // We need to remove |task_queue| from delayed_wakeup_multimap_ which is a
57 // little awkward since it's keyed by time. O(n) running time. 44 // little awkward since it's keyed by time. O(n) running time.
58 for (DelayedWakeupMultimap::iterator iter = delayed_wakeup_multimap_.begin(); 45 for (DelayedWakeupMultimap::iterator iter = delayed_wakeup_multimap_.begin();
59 iter != delayed_wakeup_multimap_.end();) { 46 iter != delayed_wakeup_multimap_.end();) {
60 if (iter->second == queue) { 47 if (iter->second == queue) {
61 destination_time_domain->ScheduleDelayedWork(queue, iter->first, 48 destination_time_domain->ScheduleDelayedWork(queue, iter->first,
62 &destination_lazy_now); 49 &destination_lazy_now);
63 DelayedWakeupMultimap::iterator temp = iter; 50 DelayedWakeupMultimap::iterator temp = iter;
64 iter++; 51 iter++;
65 // O(1) amortized. 52 // O(1) amortized.
66 delayed_wakeup_multimap_.erase(temp); 53 delayed_wakeup_multimap_.erase(temp);
67 } else { 54 } else {
68 iter++; 55 iter++;
69 } 56 }
70 } 57 }
71 58
72 // |newly_updatable_| might contain |queue|, we use 59 // |newly_updatable_| might contain |queue|, we use
73 // MoveNewlyUpdatableQueuesIntoUpdatableQueueSet to flush it out. 60 // MoveNewlyUpdatableQueuesIntoUpdatableQueueSet to flush it out.
74 MoveNewlyUpdatableQueuesIntoUpdatableQueueSet(); 61 MoveNewlyUpdatableQueuesIntoUpdatableQueueSet();
75 updatable_queue_set_.erase(queue); 62 updatable_queue_set_.erase(queue);
76
77 destination_time_domain->RegisterQueue(queue);
78 } 63 }
79 64
80 void TimeDomain::ScheduleDelayedWork(internal::TaskQueueImpl* queue, 65 void TimeDomain::ScheduleDelayedWork(internal::TaskQueueImpl* queue,
81 base::TimeTicks delayed_run_time, 66 base::TimeTicks delayed_run_time,
82 LazyNow* lazy_now) { 67 LazyNow* lazy_now) {
83 DCHECK(main_thread_checker_.CalledOnValidThread()); 68 DCHECK(main_thread_checker_.CalledOnValidThread());
84 69
85 bool delayed_wakeup_multimap_was_empty = delayed_wakeup_multimap_.empty(); 70 if (delayed_wakeup_multimap_.empty() ||
86 if (delayed_wakeup_multimap_was_empty ||
87 delayed_run_time < delayed_wakeup_multimap_.begin()->first) { 71 delayed_run_time < delayed_wakeup_multimap_.begin()->first) {
88 base::TimeDelta delay = 72 base::TimeDelta delay =
89 std::max(base::TimeDelta(), delayed_run_time - lazy_now->Now()); 73 std::max(base::TimeDelta(), delayed_run_time - lazy_now->Now());
90 RequestWakeup(lazy_now, delay); 74 RequestWakeup(lazy_now, delay);
91 } 75 }
92
93 if (observer_ && delayed_wakeup_multimap_was_empty)
94 observer_->OnTimeDomainHasDelayedWork();
95 delayed_wakeup_multimap_.insert(std::make_pair(delayed_run_time, queue)); 76 delayed_wakeup_multimap_.insert(std::make_pair(delayed_run_time, queue));
96 } 77 }
97 78
98 void TimeDomain::RegisterAsUpdatableTaskQueue(internal::TaskQueueImpl* queue) { 79 void TimeDomain::RegisterAsUpdatableTaskQueue(internal::TaskQueueImpl* queue) {
99 { 80 base::AutoLock lock(newly_updatable_lock_);
100 base::AutoLock lock(newly_updatable_lock_); 81 newly_updatable_.push_back(queue);
101 newly_updatable_.push_back(queue);
102 }
103 if (observer_)
104 observer_->OnTimeDomainHasImmediateWork();
105 } 82 }
106 83
107 void TimeDomain::UnregisterAsUpdatableTaskQueue( 84 void TimeDomain::UnregisterAsUpdatableTaskQueue(
108 internal::TaskQueueImpl* queue) { 85 internal::TaskQueueImpl* queue) {
109 DCHECK(main_thread_checker_.CalledOnValidThread()); 86 DCHECK(main_thread_checker_.CalledOnValidThread());
110 MoveNewlyUpdatableQueuesIntoUpdatableQueueSet(); 87 MoveNewlyUpdatableQueuesIntoUpdatableQueueSet();
111 #ifndef NDEBUG 88 #ifndef NDEBUG
112 { 89 {
113 base::AutoLock lock(newly_updatable_lock_); 90 base::AutoLock lock(newly_updatable_lock_);
114 DCHECK(!(updatable_queue_set_.find(queue) == updatable_queue_set_.end() && 91 DCHECK(!(updatable_queue_set_.find(queue) == updatable_queue_set_.end() &&
(...skipping 77 matching lines...) Expand 10 before | Expand all | Expand 10 after
192 state->SetString("name", GetName()); 169 state->SetString("name", GetName());
193 state->BeginArray("updatable_queue_set"); 170 state->BeginArray("updatable_queue_set");
194 for (auto& queue : updatable_queue_set_) 171 for (auto& queue : updatable_queue_set_)
195 state->AppendString(queue->GetName()); 172 state->AppendString(queue->GetName());
196 state->EndArray(); 173 state->EndArray();
197 AsValueIntoInternal(state); 174 AsValueIntoInternal(state);
198 state->EndDictionary(); 175 state->EndDictionary();
199 } 176 }
200 177
201 } // namespace scheduler 178 } // namespace scheduler
OLDNEW
« no previous file with comments | « components/scheduler/base/time_domain.h ('k') | components/scheduler/base/time_domain_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698