Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Unified Diff: Source/WebKit/chromium/public/WebDOMProgressEvent.h

Issue 14773025: Create ResourceProgressEvent, expose as Chromium API (Closed) Base URL: https://chromium.googlesource.com/chromium/blink@master
Patch Set: Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/WebKit/chromium/WebKit.gyp ('k') | Source/WebKit/chromium/src/WebDOMProgressEvent.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/WebKit/chromium/public/WebDOMProgressEvent.h
diff --git a/Source/WebKit/chromium/public/WebInbandTextTrackClient.h b/Source/WebKit/chromium/public/WebDOMProgressEvent.h
similarity index 79%
copy from Source/WebKit/chromium/public/WebInbandTextTrackClient.h
copy to Source/WebKit/chromium/public/WebDOMProgressEvent.h
index dea4043884a7cc77ab5887582b0f0658f96a66f0..c8f693842b551b6c9f1235a9c1e2f0d384285a36 100644
--- a/Source/WebKit/chromium/public/WebInbandTextTrackClient.h
+++ b/Source/WebKit/chromium/public/WebDOMProgressEvent.h
@@ -27,23 +27,26 @@
* (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
* OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
*/
+#ifndef WebDOMProgressEvent_h
+#define WebDOMProgressEvent_h
-#ifndef WebInbandTextTrackClient_h
-#define WebInbandTextTrackClient_h
+#include "WebDOMEvent.h"
+
+namespace v8 {
+class Value;
+template <class T> class Handle;
+}
namespace WebKit {
class WebString;
-class WebInbandTextTrackClient {
+class WebDOMProgressEvent : public WebDOMEvent {
public:
- virtual ~WebInbandTextTrackClient() {}
+ WebDOMProgressEvent() { }
+ WEBKIT_EXPORT WebDOMProgressEvent(const WebString& type, bool lengthIsComputable, unsigned long long loaded, unsigned long long total);
- virtual void addWebVTTCue(double start,
- double end,
- const WebString& id,
- const WebString& content,
- const WebString& settings) = 0;
+ WEBKIT_EXPORT v8::Handle<v8::Value> toV8Value();
darin (slow to review) 2013/05/14 20:14:28 I'm a bit worried about leaking implementation det
abarth-chromium 2013/05/14 20:17:50 Having toV8Value here is no good. We've decided n
};
} // namespace WebKit
« no previous file with comments | « Source/WebKit/chromium/WebKit.gyp ('k') | Source/WebKit/chromium/src/WebDOMProgressEvent.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698