Issue 14772043: With flag optimize-constructed-arrays on, ARM and MIPS suffered a performance degrade

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14772043: With flag optimize-constructed-arrays on, ARM and MIPS suffered a performance degrade (Closed)

Created:
7 years, 7 months ago by mvstanton

Modified:
7 years, 7 months ago

Reviewers:
Michael Starzinger

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

With flag optimize-constructed-arrays on, ARM and MIPS suffered a performance degrade due to incorrect code in GenerateRecordCallTarget(). The CL also enables flag optimize-constructed-arrays. BUG= R=mstarzinger@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=14692

Patch Set 1 #

Total comments: 1

Patch Set 2 : Addressed comments #

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -6 lines)			Patch
M	src/arm/code-stubs-arm.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	src/flag-definitions.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/mips/code-stubs-mips.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	test/mjsunit/allocation-site-info.js	View	1	2 chunks	+1 line, -5 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

mvstanton

Hi Michael, here is the CL we discussed, thanks! --Michael

7 years, 7 months ago (2013-05-15 14:20:54 UTC) #1

Michael Starzinger

LGTM with a nit. Nice catch. https://codereview.chromium.org/14772043/diff/1/test/mjsunit/allocation-site-info.js File test/mjsunit/allocation-site-info.js (right): https://codereview.chromium.org/14772043/diff/1/test/mjsunit/allocation-site-info.js#newcode31 test/mjsunit/allocation-site-info.js:31: // TODO(mvstanton): remove ...

7 years, 7 months ago (2013-05-15 14:26:22 UTC) #2

mvstanton

7 years, 7 months ago (2013-05-15 15:17:12 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r14692 (presubmit successful).

Expand Messages | Collapse Messages