Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Side by Side Diff: src/mips/code-stubs-mips.cc

Issue 14772043: With flag optimize-constructed-arrays on, ARM and MIPS suffered a performance degrade (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Addressed comments Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/flag-definitions.h ('k') | test/mjsunit/allocation-site-info.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 5140 matching lines...) Expand 10 before | Expand all | Expand 10 after
5151 5151
5152 // A monomorphic miss (i.e, here the cache is not uninitialized) goes 5152 // A monomorphic miss (i.e, here the cache is not uninitialized) goes
5153 // megamorphic. 5153 // megamorphic.
5154 __ LoadRoot(at, Heap::kTheHoleValueRootIndex); 5154 __ LoadRoot(at, Heap::kTheHoleValueRootIndex);
5155 __ Branch(&initialize, eq, a3, Operand(at)); 5155 __ Branch(&initialize, eq, a3, Operand(at));
5156 // MegamorphicSentinel is an immortal immovable object (undefined) so no 5156 // MegamorphicSentinel is an immortal immovable object (undefined) so no
5157 // write-barrier is needed. 5157 // write-barrier is needed.
5158 __ bind(&megamorphic); 5158 __ bind(&megamorphic);
5159 __ LoadRoot(at, Heap::kUndefinedValueRootIndex); 5159 __ LoadRoot(at, Heap::kUndefinedValueRootIndex);
5160 __ sw(at, FieldMemOperand(a2, JSGlobalPropertyCell::kValueOffset)); 5160 __ sw(at, FieldMemOperand(a2, JSGlobalPropertyCell::kValueOffset));
5161 __ jmp(&done);
5161 5162
5162 // An uninitialized cache is patched with the function or sentinel to 5163 // An uninitialized cache is patched with the function or sentinel to
5163 // indicate the ElementsKind if function is the Array constructor. 5164 // indicate the ElementsKind if function is the Array constructor.
5164 __ bind(&initialize); 5165 __ bind(&initialize);
5165 // Make sure the function is the Array() function 5166 // Make sure the function is the Array() function
5166 __ LoadArrayFunction(a3); 5167 __ LoadArrayFunction(a3);
5167 __ Branch(&not_array_function, ne, a1, Operand(a3)); 5168 __ Branch(&not_array_function, ne, a1, Operand(a3));
5168 5169
5169 // The target function is the Array constructor, install a sentinel value in 5170 // The target function is the Array constructor, install a sentinel value in
5170 // the constructor's type info cell that will track the initial ElementsKind 5171 // the constructor's type info cell that will track the initial ElementsKind
(...skipping 2677 matching lines...) Expand 10 before | Expand all | Expand 10 after
7848 __ Jump(generic_construct_stub, RelocInfo::CODE_TARGET); 7849 __ Jump(generic_construct_stub, RelocInfo::CODE_TARGET);
7849 } 7850 }
7850 } 7851 }
7851 7852
7852 7853
7853 #undef __ 7854 #undef __
7854 7855
7855 } } // namespace v8::internal 7856 } } // namespace v8::internal
7856 7857
7857 #endif // V8_TARGET_ARCH_MIPS 7858 #endif // V8_TARGET_ARCH_MIPS
OLDNEW
« no previous file with comments | « src/flag-definitions.h ('k') | test/mjsunit/allocation-site-info.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698