Treats empty layout as expected.

Treats empty layout as expected.

There is a case that empty layout is good to use. We can fall-back it to
hardware keyboard layout.

BUG=239451
TEST=Manually confirmed

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=199686

[Seigo Nonaka, 2013-05-09 14:32:15]

Hi Zach,

Could you take an look?

Thank you.

[Zachary Kuznia, 2013-05-10 03:59:45]

lgtm

[Seigo Nonaka, 2013-05-10 05:14:34]

Zach, thank you for your review!

Adding mpcomplete@ as the extension owner.

Hi Matt, could you take an owner review?

Thank you.
Seigo.

[Matt Perry, 2013-05-10 16:54:10]

https://codereview.chromium.org/14772016/diff/1/chrome/common/extensions/api/...
File chrome/common/extensions/api/input_ime/input_components_handler.cc (right):

https://codereview.chromium.org/14772016/diff/1/chrome/common/extensions/api/...
chrome/common/extensions/api/input_ime/input_components_handler.cc:132:
layouts_value = new ListValue();
layouts_value is never used. This will leak.

[Seigo Nonaka, 2013-05-10 18:03:59]

Thank you for your review! PTAL?

https://codereview.chromium.org/14772016/diff/1/chrome/common/extensions/api/...
File chrome/common/extensions/api/input_ime/input_components_handler.cc (right):

https://codereview.chromium.org/14772016/diff/1/chrome/common/extensions/api/...
chrome/common/extensions/api/input_ime/input_components_handler.cc:132:
layouts_value = new ListValue();
Yes, nice catch!

On 2013/05/10 16:54:10, Matt Perry wrote:
> layouts_value is never used. This will leak.

[Matt Perry, 2013-05-10 19:14:30]

lgtm

[commit-bot: I haz the power, 2013-05-13 02:28:00]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/nona@chromium.org/14772016/7001

[commit-bot: I haz the power, 2013-05-13 08:26:19]

Change committed as 199686