Treats empty layout as expected.

chrome/common/extensions/api/input_ime/input_components_handler.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/common/extensions/api/input_ime/input_components_handler.h"
 
 #include "base/memory/scoped_ptr.h"
 #include "base/string_util.h"
 #include "base/strings/string_number_conversions.h"
 #include "base/utf_string_conversions.h"
@@ skipping 99 matching lines @@
       return false;
     }
 
     // Get input_components[i].language.
     if (!module_value->GetString(keys::kLanguage, &language_str)) {
       language_str = "";
     }
 
     // Get input_components[i].layouts.
     const ListValue* layouts_value = NULL;
-    if (!module_value->GetList(keys::kLayouts, &layouts_value)) {
-      *error = ASCIIToUTF16(
-          errors::kInvalidInputComponentLayouts);
-      return false;
-    }
-
-    for (size_t j = 0; j < layouts_value->GetSize(); ++j) {
-      std::string layout_name_str;
-      if (!layouts_value->GetString(j, &layout_name_str)) {
-        *error = ErrorUtils::FormatErrorMessageUTF16(
-            errors::kInvalidInputComponentLayoutName,
-            base::IntToString(i), base::IntToString(j));
-        return false;
+    if (module_value->GetList(keys::kLayouts, &layouts_value)) {
+      for (size_t j = 0; j < layouts_value->GetSize(); ++j) {
+        std::string layout_name_str;
+        if (!layouts_value->GetString(j, &layout_name_str)) {
+          *error = ErrorUtils::FormatErrorMessageUTF16(
+              errors::kInvalidInputComponentLayoutName,
+              base::IntToString(i), base::IntToString(j));
+          return false;
+        }
+        layouts.insert(layout_name_str);
       }
-      layouts.insert(layout_name_str);
+    } else {
+      layouts_value = new ListValue();

[Matt Perry, 2013/05/10 16:54:10]

layouts_value is never used. This will leak.

[Seigo Nonaka, 2013/05/10 18:04:00]

Yes, nice catch!

On 2013/05/10 16:54:10, Matt Perry wrote:

     }
 
     if (module_value->HasKey(keys::kShortcutKey)) {
       const DictionaryValue* shortcut_value = NULL;
       if (!module_value->GetDictionary(keys::kShortcutKey,
           &shortcut_value)) {
         *error = ErrorUtils::FormatErrorMessageUTF16(
             errors::kInvalidInputComponentShortcutKey,
             base::IntToString(i));
         return false;
@@ skipping 38 matching lines @@
   }
   extension->SetManifestData(keys::kInputComponents, info.release());
   return true;
 }
 
 const std::vector<std::string> InputComponentsHandler::Keys() const {
   return SingleKey(keys::kInputComponents);
 }
 
 }  // namespace extensions