Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1477163002: Factory should always set the constant pool offset. (Closed)

Created:
5 years ago by titzer
Modified:
5 years ago
Reviewers:
Jakob Kummerow
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Factory should always set the constant pool offset. R=jkummerow@chromium.org BUG= Committed: https://crrev.com/c82bbf319a19d774eb9941c4ef904f12c883e951 Cr-Commit-Position: refs/heads/master@{#32329}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -3 lines) Patch
M src/factory.cc View 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
titzer
5 years ago (2015-11-26 09:56:47 UTC) #1
Jakob Kummerow
lgtm
5 years ago (2015-11-26 09:57:55 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1477163002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1477163002/1
5 years ago (2015-11-26 10:19:40 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-11-26 10:43:33 UTC) #5
commit-bot: I haz the power
5 years ago (2015-11-26 10:44:06 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/c82bbf319a19d774eb9941c4ef904f12c883e951
Cr-Commit-Position: refs/heads/master@{#32329}

Powered by Google App Engine
This is Rietveld 408576698