Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(224)

Side by Side Diff: src/factory.cc

Issue 1477163002: Factory should always set the constant pool offset. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/factory.h" 5 #include "src/factory.h"
6 6
7 #include "src/allocation-site-scopes.h" 7 #include "src/allocation-site-scopes.h"
8 #include "src/base/bits.h" 8 #include "src/base/bits.h"
9 #include "src/bootstrapper.h" 9 #include "src/bootstrapper.h"
10 #include "src/conversions.h" 10 #include "src/conversions.h"
(...skipping 1405 matching lines...) Expand 10 before | Expand all | Expand 10 after
1416 code->set_relocation_info(*reloc_info); 1416 code->set_relocation_info(*reloc_info);
1417 code->set_flags(flags); 1417 code->set_flags(flags);
1418 code->set_raw_kind_specific_flags1(0); 1418 code->set_raw_kind_specific_flags1(0);
1419 code->set_raw_kind_specific_flags2(0); 1419 code->set_raw_kind_specific_flags2(0);
1420 code->set_is_crankshafted(crankshafted); 1420 code->set_is_crankshafted(crankshafted);
1421 code->set_deoptimization_data(*empty_fixed_array(), SKIP_WRITE_BARRIER); 1421 code->set_deoptimization_data(*empty_fixed_array(), SKIP_WRITE_BARRIER);
1422 code->set_raw_type_feedback_info(Smi::FromInt(0)); 1422 code->set_raw_type_feedback_info(Smi::FromInt(0));
1423 code->set_next_code_link(*undefined_value()); 1423 code->set_next_code_link(*undefined_value());
1424 code->set_handler_table(*empty_fixed_array(), SKIP_WRITE_BARRIER); 1424 code->set_handler_table(*empty_fixed_array(), SKIP_WRITE_BARRIER);
1425 code->set_prologue_offset(prologue_offset); 1425 code->set_prologue_offset(prologue_offset);
1426 if (FLAG_enable_embedded_constant_pool) { 1426 code->set_constant_pool_offset(desc.instr_size - desc.constant_pool_size);
1427 code->set_constant_pool_offset(desc.instr_size - desc.constant_pool_size); 1427
1428 }
1429 if (code->kind() == Code::OPTIMIZED_FUNCTION) { 1428 if (code->kind() == Code::OPTIMIZED_FUNCTION) {
1430 code->set_marked_for_deoptimization(false); 1429 code->set_marked_for_deoptimization(false);
1431 } 1430 }
1432 1431
1433 if (is_debug) { 1432 if (is_debug) {
1434 DCHECK(code->kind() == Code::FUNCTION); 1433 DCHECK(code->kind() == Code::FUNCTION);
1435 code->set_has_debug_break_slots(true); 1434 code->set_has_debug_break_slots(true);
1436 } 1435 }
1437 1436
1438 // Allow self references to created code object by patching the handle to 1437 // Allow self references to created code object by patching the handle to
(...skipping 888 matching lines...) Expand 10 before | Expand all | Expand 10 after
2327 } 2326 }
2328 2327
2329 2328
2330 Handle<Object> Factory::ToBoolean(bool value) { 2329 Handle<Object> Factory::ToBoolean(bool value) {
2331 return value ? true_value() : false_value(); 2330 return value ? true_value() : false_value();
2332 } 2331 }
2333 2332
2334 2333
2335 } // namespace internal 2334 } // namespace internal
2336 } // namespace v8 2335 } // namespace v8
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698