Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Issue 1477113002: Revert of Devtools Animations: Maintain playback rate on navigation (Closed)

Created:
5 years ago by pfeldman
Modified:
5 years ago
Reviewers:
dstockwell, samli
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-animation_chromium.org, caseq+blink_chromium.org, chromium-reviews, devtools-reviews_chromium.org, Eric Willigers, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, rjwright, sergeyv+blink_chromium.org, shans
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Devtools Animations: Maintain playback rate on navigation (patchset #1 id:1 of https://codereview.chromium.org/1471193008/ ) Reason for revert: Reverting while we are figuring out if this is the right thing to do. Original issue's description: > Devtools Animations: Maintain playback rate on navigation > > This change allows slowdown of on-load animations and does not affect > the playback rate when devtools is closed. > > BUG=447083 > > Committed: https://crrev.com/07835d0da6848630e58505a7e0ac4f560978d726 > Cr-Commit-Position: refs/heads/master@{#361834} TBR=dstockwell@chromium.org,samli@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=447083 Committed: https://crrev.com/9445ed531405cfb01f9f67e24f1038a3640c0179 Cr-Commit-Position: refs/heads/master@{#361846}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4 lines) Patch
M third_party/WebKit/Source/devtools/front_end/animation/AnimationModel.js View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
pfeldman
Created Revert of Devtools Animations: Maintain playback rate on navigation
5 years ago (2015-11-26 08:14:07 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1477113002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1477113002/1
5 years ago (2015-11-26 08:14:17 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-11-26 08:14:45 UTC) #3
commit-bot: I haz the power
5 years ago (2015-11-26 08:15:39 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9445ed531405cfb01f9f67e24f1038a3640c0179
Cr-Commit-Position: refs/heads/master@{#361846}

Powered by Google App Engine
This is Rietveld 408576698