Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issue 1477073005: Use new.target in favor of %_IsConstructCall intrinsic (1). (Closed)

Created:
5 years ago by Michael Starzinger
Modified:
5 years ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Use new.target in favor of %_IsConstructCall intrinsic (1). This switches several builtin methods to use the ES6 new.target value when determined whether being called as a constructor or not. This is prepatory work for fully deprecating the aforementioned intrinsic. R=rossberg@chromium.org Committed: https://crrev.com/b1578a15abbb6c4fcc7ceadde1602333af369cee Cr-Commit-Position: refs/heads/master@{#32397}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -18 lines) Patch
M src/js/collection.js View 2 chunks +2 lines, -2 lines 0 comments Download
M src/js/harmony-sharedarraybuffer.js View 1 chunk +1 line, -1 line 0 comments Download
M src/js/harmony-simd.js View 5 chunks +30 lines, -10 lines 0 comments Download
M src/js/messages.js View 1 chunk +1 line, -1 line 0 comments Download
M src/js/proxy.js View 2 chunks +2 lines, -2 lines 0 comments Download
M src/js/weak-collection.js View 2 chunks +2 lines, -2 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 10 (5 generated)
Michael Starzinger
5 years ago (2015-11-27 12:08:36 UTC) #1
Benedikt Meurer
LGTM.
5 years ago (2015-11-30 10:26:58 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1477073005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1477073005/1
5 years ago (2015-11-30 10:28:20 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-11-30 10:48:26 UTC) #8
commit-bot: I haz the power
5 years ago (2015-11-30 10:48:37 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b1578a15abbb6c4fcc7ceadde1602333af369cee
Cr-Commit-Position: refs/heads/master@{#32397}

Powered by Google App Engine
This is Rietveld 408576698