Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 1474343002: Use new.target in favor of %_IsConstructCall intrinsic (2). (Closed)

Created:
5 years ago by Michael Starzinger
Modified:
5 years ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@local_js-use-new-target-1
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Use new.target in favor of %_IsConstructCall intrinsic (2). This switches all remaining builtin methods to use the ES6 new.target value when determined whether being called as a constructor or not. This is prepatory work for fully deprecating the aforementioned intrinsic. R=rossberg@chromium.org Committed: https://crrev.com/9090c6b0127d94eca00ccf9675ca5204a70be097 Cr-Commit-Position: refs/heads/master@{#32447}

Patch Set 1 #

Patch Set 2 : Skip ignition. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -21 lines) Patch
M src/js/arraybuffer.js View 1 chunk +1 line, -1 line 0 comments Download
M src/js/i18n.js View 15 chunks +17 lines, -17 lines 0 comments Download
M src/js/typedarray.js View 1 chunk +1 line, -1 line 0 comments Download
M src/js/v8natives.js View 2 chunks +2 lines, -2 lines 0 comments Download
M test/mjsunit/mjsunit.status View 1 1 chunk +1 line, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 15 (8 generated)
Michael Starzinger
This CL requires TurboFan to be shipped with new.target references, otherwise optimization of the touched ...
5 years ago (2015-11-27 14:50:49 UTC) #2
Benedikt Meurer
lgtm
5 years ago (2015-11-30 10:29:31 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1474343002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1474343002/1
5 years ago (2015-12-01 09:46:50 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_arm64_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel/builds/12387)
5 years ago (2015-12-01 09:51:06 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1474343002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1474343002/20001
5 years ago (2015-12-01 10:33:29 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years ago (2015-12-01 10:50:29 UTC) #13
commit-bot: I haz the power
5 years ago (2015-12-01 10:50:38 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/9090c6b0127d94eca00ccf9675ca5204a70be097
Cr-Commit-Position: refs/heads/master@{#32447}

Powered by Google App Engine
This is Rietveld 408576698