third_party/WebKit/Source/modules/accessibility/AXNodeObject.h - Issue 1477043003: Handle aria-owns and presentational children in AX name calc.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/accessibility/AXNodeObject.h

Issue 1477043003: Handle aria-owns and presentational children in AX name calc. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@garaventa_visibility_hidden

Patch Set: Better solution to handle both aria-owns and role=presentation in name calc Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/accessibility/AXLayoutObject.cpp ('k') | third_party/WebKit/Source/modules/accessibility/AXNodeObject.cpp » ('j') | third_party/WebKit/Source/modules/accessibility/AXNodeObject.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/accessibility/AXNodeObject.h

diff --git a/third_party/WebKit/Source/modules/accessibility/AXNodeObject.h b/third_party/WebKit/Source/modules/accessibility/AXNodeObject.h

index 77a593ae22596806b9a391dc39120fd27423894e..2739bbcb8cc009a5566dcc6af5183c2de6ab8c73 100644

--- a/third_party/WebKit/Source/modules/accessibility/AXNodeObject.h

+++ b/third_party/WebKit/Source/modules/accessibility/AXNodeObject.h

@@ -171,7 +171,7 @@ protected:

// Low-level accessibility tree exploration.

AXObject* rawFirstChild() const override;

- AXObject* rawFirstSibling() const override;

+ AXObject* rawNextSibling() const override;

void addChildren() override;

bool canHaveChildren() const override;

void addChild(AXObject*);

@@ -199,13 +199,13 @@ protected:

int setSize() const override;

// Aria-owns.

- void computeAriaOwnsChildren(HeapVector<Member<AXObject>>& ownedChildren);

+ void computeAriaOwnsChildren(HeapVector<Member<AXObject>>& ownedChildren) const;

private:

RawPtrWillBeMember<Node> m_node;

bool isNativeCheckboxInMixedState() const;

- String textFromDescendants(AXObjectSet& visited) const;

+ String textFromDescendants(AXObjectSet& visited, bool recursive) const override;

String nativeTextAlternative(AXObjectSet& visited, AXNameFrom&, AXRelatedObjectVector*, NameSources*, bool* foundTextAlternative) const;

float stepValueForRange() const;

AXObject* findChildWithTagName(const HTMLQualifiedName&) const;