third_party/WebKit/Source/modules/accessibility/AXLayoutObject.cpp - Issue 1477043003: Handle aria-owns and presentational children in AX name calc.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/accessibility/AXLayoutObject.cpp

Issue 1477043003: Handle aria-owns and presentational children in AX name calc. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@garaventa_visibility_hidden

Patch Set: Better solution to handle both aria-owns and role=presentation in name calc Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/accessibility/AXLayoutObject.h ('k') | third_party/WebKit/Source/modules/accessibility/AXNodeObject.h » ('j') | third_party/WebKit/Source/modules/accessibility/AXNodeObject.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/accessibility/AXLayoutObject.cpp

diff --git a/third_party/WebKit/Source/modules/accessibility/AXLayoutObject.cpp b/third_party/WebKit/Source/modules/accessibility/AXLayoutObject.cpp

index 26df49e858dcc7d1ec6542f99c0039b27032db21..b6487be73ea8c9fc21339883419722fb32f56a6b 100644

--- a/third_party/WebKit/Source/modules/accessibility/AXLayoutObject.cpp

+++ b/third_party/WebKit/Source/modules/accessibility/AXLayoutObject.cpp

@@ -1441,7 +1441,7 @@ void AXLayoutObject::markCachedElementRectDirty() const

// Marks children recursively, if this element changed.

m_cachedElementRectDirty = true;

- for (AXObject* child = rawFirstChild(); child; child = child->rawFirstSibling())

+ for (AXObject* child = rawFirstChild(); child; child = child->rawNextSibling())

child->markCachedElementRectDirty();

}

@@ -1593,7 +1593,7 @@ AXObject* AXLayoutObject::rawFirstChild() const

return axObjectCache().getOrCreate(firstChild);

}

-AXObject* AXLayoutObject::rawFirstSibling() const

+AXObject* AXLayoutObject::rawNextSibling() const

{

if (!m_layoutObject)

return 0;

@@ -1652,7 +1652,7 @@ void AXLayoutObject::addChildren()

HeapVector<Member<AXObject>> ownedChildren;

computeAriaOwnsChildren(ownedChildren);

- for (AXObject* obj = rawFirstChild(); obj; obj = obj->rawFirstSibling()) {

+ for (AXObject* obj = rawFirstChild(); obj; obj = obj->rawNextSibling()) {

if (!axObjectCache().isAriaOwned(obj))

addChild(obj);

}