Identity API: Add component app for auth flow UI

Identity API: Add component app for auth flow UI

All Identity API UI is moving into a webview tag inside a component
app, allowing Chrome Apps to be isolated from the browser.

This change adds a component app that displays a webview based dialog
box, and a private API used to launch the app and load its resources.

BUG=228908
(This is part of step #6 in the description.)

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=201736

[Michael Courage, 2013-05-08 23:40:54]

This is just the component app from https://codereview.chromium.org/14081014/,
and the private API that supports it.

Does this look like the right size chunk of functionality? I could have further
split out the identityPrivate API, but it doesn't make a lot of sense without
the app.

[Michael Courage, 2013-05-10 19:01:27]

ping. Let me know if there's anything more I can do with this review to make it
easier

[James Hawkins, 2013-05-10 19:08:35]

I will get to this, but probably not until Monday.  I'm crushed under I/O right
now.

[Michael Courage, 2013-05-10 19:59:05]

OK, thanks for the update.

[Michael Courage, 2013-05-13 21:32:44]

Dan, can you review chrome/browser/resources since James is super-busy with I/O?
 I'd like to get this in as soon as I can for a UI review of the implementation.
Getting identity going in M29 is a high-priority for apps v2.

[Dan Beam, 2013-05-13 21:45:53]

every owner in c/b/resources or c/b/ui/webui is busy with I/O except arv@
(estade@, jhawkins, and I are all presenting)

[James Hawkins, 2013-05-13 22:24:06]

https://codereview.chromium.org/14768009/diff/5001/chrome/browser/resources/i...
File chrome/browser/resources/identity_api_ui/identity_api_ui.css (right):

https://codereview.chromium.org/14768009/diff/5001/chrome/browser/resources/i...
chrome/browser/resources/identity_api_ui/identity_api_ui.css:1: /* Copyright (c)
2013 The Chromium Authors. All rights reserved.
nit: Please find a better name for this dir and set of files.  I'm not a fan of
calling it 'blah UI'.

https://codereview.chromium.org/14768009/diff/5001/chrome/browser/resources/i...
chrome/browser/resources/identity_api_ui/identity_api_ui.css:6: margin: 0;
Why is this necessary?

https://codereview.chromium.org/14768009/diff/5001/chrome/browser/resources/i...
File chrome/browser/resources/identity_api_ui/identity_api_ui.js (right):

https://codereview.chromium.org/14768009/diff/5001/chrome/browser/resources/i...
chrome/browser/resources/identity_api_ui/identity_api_ui.js:5:
chrome.identityPrivate.onWebFlowRequest.addListener(
Is this a background page, or what?  Should we be waiting for onload?

https://codereview.chromium.org/14768009/diff/5001/chrome/browser/resources/i...
File chrome/browser/resources/identity_api_ui/scope_approval_dialog.html
(right):

https://codereview.chromium.org/14768009/diff/5001/chrome/browser/resources/i...
chrome/browser/resources/identity_api_ui/scope_approval_dialog.html:3:
<title>Identity API Scope Approval Dialog</title>
Needs to be localized.

https://codereview.chromium.org/14768009/diff/5001/chrome/browser/resources/i...
chrome/browser/resources/identity_api_ui/scope_approval_dialog.html:11: <script
src="scope_approval_dialog.js"></script>
Why is this not in the head element?

https://codereview.chromium.org/14768009/diff/5001/chrome/browser/resources/i...
File chrome/browser/resources/identity_api_ui/scope_approval_dialog.js (right):

https://codereview.chromium.org/14768009/diff/5001/chrome/browser/resources/i...
chrome/browser/resources/identity_api_ui/scope_approval_dialog.js:7: function
start(url, win) {
nit: Document method (and rename it to be more descriptive).

[Michael Courage, 2013-05-14 17:10:56]

Thanks for making time during what I'm sure is a crazy week.

https://codereview.chromium.org/14768009/diff/5001/chrome/browser/resources/i...
File chrome/browser/resources/identity_api_ui/identity_api_ui.css (right):

https://codereview.chromium.org/14768009/diff/5001/chrome/browser/resources/i...
chrome/browser/resources/identity_api_ui/identity_api_ui.css:1: /* Copyright (c)
2013 The Chromium Authors. All rights reserved.
On 2013/05/13 22:24:07, James Hawkins wrote:
> nit: Please find a better name for this dir and set of files.  I'm not a fan
of
> calling it 'blah UI'.

Done.

https://codereview.chromium.org/14768009/diff/5001/chrome/browser/resources/i...
chrome/browser/resources/identity_api_ui/identity_api_ui.css:6: margin: 0;
On 2013/05/13 22:24:07, James Hawkins wrote:
> Why is this necessary?

removed

https://codereview.chromium.org/14768009/diff/5001/chrome/browser/resources/i...
File chrome/browser/resources/identity_api_ui/identity_api_ui.js (right):

https://codereview.chromium.org/14768009/diff/5001/chrome/browser/resources/i...
chrome/browser/resources/identity_api_ui/identity_api_ui.js:5:
chrome.identityPrivate.onWebFlowRequest.addListener(
On 2013/05/13 22:24:07, James Hawkins wrote:
> Is this a background page, or what?  Should we be waiting for onload?

This is the background page for the app. There isn't really anything useful to
do in onLaunched or any of the regular chrome.runtime events though.

The onWebFlow request fires whenever there is a call to
identity.launchWebAuthFlow from any app or extension.

https://codereview.chromium.org/14768009/diff/5001/chrome/browser/resources/i...
File chrome/browser/resources/identity_api_ui/scope_approval_dialog.html
(right):

https://codereview.chromium.org/14768009/diff/5001/chrome/browser/resources/i...
chrome/browser/resources/identity_api_ui/scope_approval_dialog.html:3:
<title>Identity API Scope Approval Dialog</title>
On 2013/05/13 22:24:07, James Hawkins wrote:
> Needs to be localized.

Would it be ok to just remove the title? It doesn't actually get displayed due
to the custom window frame.

https://codereview.chromium.org/14768009/diff/5001/chrome/browser/resources/i...
chrome/browser/resources/identity_api_ui/scope_approval_dialog.html:11: <script
src="scope_approval_dialog.js"></script>
On 2013/05/13 22:24:07, James Hawkins wrote:
> Why is this not in the head element?

Just to avoid having to wait for DOMContentLoaded in the script. Moved to head.

https://codereview.chromium.org/14768009/diff/5001/chrome/browser/resources/i...
File chrome/browser/resources/identity_api_ui/scope_approval_dialog.js (right):

https://codereview.chromium.org/14768009/diff/5001/chrome/browser/resources/i...
chrome/browser/resources/identity_api_ui/scope_approval_dialog.js:7: function
start(url, win) {
On 2013/05/13 22:24:07, James Hawkins wrote:
> nit: Document method (and rename it to be more descriptive).

Done.

[James Hawkins, 2013-05-15 15:24:45]

https://codereview.chromium.org/14768009/diff/5001/chrome/browser/resources/i...
File chrome/browser/resources/identity_api_ui/scope_approval_dialog.html
(right):

https://codereview.chromium.org/14768009/diff/5001/chrome/browser/resources/i...
chrome/browser/resources/identity_api_ui/scope_approval_dialog.html:3:
<title>Identity API Scope Approval Dialog</title>
On 2013/05/14 17:10:56, Michael Courage wrote:
> On 2013/05/13 22:24:07, James Hawkins wrote:
> > Needs to be localized.
> 
> Would it be ok to just remove the title? It doesn't actually get displayed due
> to the custom window frame.

Yes, remove it if it's not visible.  Are you sure it's not visible, though?  I
think it's visible in chrome:inspect.  It's also likely visibly in the window
managers of some OSes, e.g., a task/window switcher.

[Michael Courage, 2013-05-15 18:39:34]

https://codereview.chromium.org/14768009/diff/5001/chrome/browser/resources/i...
File chrome/browser/resources/identity_api_ui/scope_approval_dialog.html
(right):

https://codereview.chromium.org/14768009/diff/5001/chrome/browser/resources/i...
chrome/browser/resources/identity_api_ui/scope_approval_dialog.html:3:
<title>Identity API Scope Approval Dialog</title>
On 2013/05/15 15:24:45, James Hawkins wrote:
> > > Needs to be localized.
> Yes, remove it if it's not visible.  Are you sure it's not visible, though?  I
> think it's visible in chrome:inspect.  It's also likely visibly in the window
> managers of some OSes, e.g., a task/window switcher.

You're right, it's visible after all. I added a title, using the string that we
used for native OAuth permission dialogs in the experimental identity API.

[Michael Courage, 2013-05-21 17:30:49]

ping

[James Hawkins, 2013-05-21 18:05:14]

LGTM with nits.

https://codereview.chromium.org/14768009/diff/60001/chrome/browser/resources/...
File chrome/browser/resources/identity_scope_approval_dialog/background.js
(right):

https://codereview.chromium.org/14768009/diff/60001/chrome/browser/resources/...
chrome/browser/resources/identity_scope_approval_dialog/background.js:5:
function showAuthDialog(key, url, mode) {
nit: Document method and params.

https://codereview.chromium.org/14768009/diff/60001/chrome/browser/resources/...
chrome/browser/resources/identity_scope_approval_dialog/background.js:16:
function initializeWebFlow(win) {
Optional nit: Either inline this function into the invocation parameter or pull
it out into its own method (not sub-method).

https://codereview.chromium.org/14768009/diff/60001/chrome/browser/resources/...
File
chrome/browser/resources/identity_scope_approval_dialog/scope_approval_dialog.html
(right):

https://codereview.chromium.org/14768009/diff/60001/chrome/browser/resources/...
chrome/browser/resources/identity_scope_approval_dialog/scope_approval_dialog.html:3:
<link rel="stylesheet" type="text/css" href="scope_approval_dialog.css"/>
nit: Remove /

[Michael Courage, 2013-05-21 19:10:21]

https://codereview.chromium.org/14768009/diff/60001/chrome/browser/resources/...
File chrome/browser/resources/identity_scope_approval_dialog/background.js
(right):

https://codereview.chromium.org/14768009/diff/60001/chrome/browser/resources/...
chrome/browser/resources/identity_scope_approval_dialog/background.js:5:
function showAuthDialog(key, url, mode) {
On 2013/05/21 18:05:14, James Hawkins wrote:
> nit: Document method and params.

Done.

https://codereview.chromium.org/14768009/diff/60001/chrome/browser/resources/...
chrome/browser/resources/identity_scope_approval_dialog/background.js:16:
function initializeWebFlow(win) {
On 2013/05/21 18:05:14, James Hawkins wrote:
> Optional nit: Either inline this function into the invocation parameter or
pull
> it out into its own method (not sub-method).

Done.

https://codereview.chromium.org/14768009/diff/60001/chrome/browser/resources/...
File
chrome/browser/resources/identity_scope_approval_dialog/scope_approval_dialog.html
(right):

https://codereview.chromium.org/14768009/diff/60001/chrome/browser/resources/...
chrome/browser/resources/identity_scope_approval_dialog/scope_approval_dialog.html:3:
<link rel="stylesheet" type="text/css" href="scope_approval_dialog.css"/>
On 2013/05/21 18:05:14, James Hawkins wrote:
> nit: Remove /

Done.

[miket_OOO, 2013-05-21 19:52:49]

lgtm

https://codereview.chromium.org/14768009/diff/76001/chrome/browser/resources/...
File chrome/browser/resources/identity_scope_approval_dialog/manifest.json
(right):

https://codereview.chromium.org/14768009/diff/76001/chrome/browser/resources/...
chrome/browser/resources/identity_scope_approval_dialog/manifest.json:10:
"identityPrivate",
Indentation nonstandard

[Michael Courage, 2013-05-21 20:29:45]

https://codereview.chromium.org/14768009/diff/76001/chrome/browser/resources/...
File chrome/browser/resources/identity_scope_approval_dialog/manifest.json
(right):

https://codereview.chromium.org/14768009/diff/76001/chrome/browser/resources/...
chrome/browser/resources/identity_scope_approval_dialog/manifest.json:10:
"identityPrivate",
On 2013/05/21 19:52:49, miket wrote:
> Indentation nonstandard

Done.

[commit-bot: I haz the power, 2013-05-21 20:31:15]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/courage@chromium.org/14768009/84001

[commit-bot: I haz the power, 2013-05-22 03:23:00]

Retried try job too often on win_rel for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2013-05-22 17:44:33]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/courage@chromium.org/14768009/101001

[commit-bot: I haz the power, 2013-05-23 10:34:56]

Change committed as 201736