chrome/browser/resources/identity_api_ui/scope_approval_dialog.html - Issue 14768009: Identity API: Add component app for auth flow UI

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/resources/identity_api_ui/scope_approval_dialog.html

Issue 14768009: Identity API: Add component app for auth flow UI (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: no permission message for identityPrivate Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« chrome/browser/resources/identity_api_ui/identity_api_ui.js ('K') | « chrome/browser/resources/identity_api_ui/manifest.json ('k') | chrome/browser/resources/identity_api_ui/scope_approval_dialog.js » ('j') | chrome/browser/resources/identity_api_ui/scope_approval_dialog.js » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <html>

	2 <head>

	3 <title>Identity API Scope Approval Dialog</title>
	James Hawkins 2013/05/13 22:24:07 Needs to be localized. Needs to be localized. Michael Courage 2013/05/14 17:10:56 Would it be ok to just remove the title? It doesn' Show quoted text On 2013/05/13 22:24:07, James Hawkins wrote: > Needs to be localized. Would it be ok to just remove the title? It doesn't actually get displayed due to the custom window frame. James Hawkins 2013/05/15 15:24:45 Yes, remove it if it's not visible. Are you sure Show quoted text On 2013/05/14 17:10:56, Michael Courage wrote: > On 2013/05/13 22:24:07, James Hawkins wrote: > > Needs to be localized. > > Would it be ok to just remove the title? It doesn't actually get displayed due > to the custom window frame. Yes, remove it if it's not visible. Are you sure it's not visible, though? I think it's visible in chrome:inspect. It's also likely visibly in the window managers of some OSes, e.g., a task/window switcher. Michael Courage 2013/05/15 18:39:35 You're right, it's visible after all. I added a ti Show quoted text On 2013/05/15 15:24:45, James Hawkins wrote: > > > Needs to be localized. > Yes, remove it if it's not visible. Are you sure it's not visible, though? I > think it's visible in chrome:inspect. It's also likely visibly in the window > managers of some OSes, e.g., a task/window switcher. You're right, it's visible after all. I added a title, using the string that we used for native OAuth permission dialogs in the experimental identity API.
	4 <link rel="stylesheet" type="text/css" href="identity_api_ui.css"/>

	5 </head>

	6 <body>

	7 <div class="titlebar">

	8 <span class="titlebar-close-button"></span>

	9 </div>

	10 <webview class="content" id="providerview" autosize="true"></webview>

	11 <script src="scope_approval_dialog.js"></script>
	James Hawkins 2013/05/13 22:24:07 Why is this not in the head element? Why is this not in the head element? Michael Courage 2013/05/14 17:10:56 Just to avoid having to wait for DOMContentLoaded Show quoted text On 2013/05/13 22:24:07, James Hawkins wrote: > Why is this not in the head element? Just to avoid having to wait for DOMContentLoaded in the script. Moved to head.
	12 </body>

	13 </html>

OLD	NEW