Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 1476763003: Roll HarfBuzz to 1.1.1 (Closed)

Created:
5 years ago by drott
Modified:
5 years ago
Reviewers:
kojii, eae, yurys, behdad
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Roll HarfBuzz to 1.1.1 Integrating the unicode compatibility decomposition and shaping of whitespace fixes. BUG=558707 R=eae,kojii,behdad Committed: https://crrev.com/c3c69f0e2aefe7bfdf04cdf88883a24955112d64 Cr-Commit-Position: refs/heads/master@{#362116}

Patch Set 1 #

Patch Set 2 : rolling to 1.1.1 #

Patch Set 3 : Rebaseline #

Patch Set 4 : windows line height rebaseline #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1208 lines, -455 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 2 3 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/harfbuzz-ng/NEWS View 1 1 chunk +29 lines, -0 lines 0 comments Download
M third_party/harfbuzz-ng/README.chromium View 1 2 chunks +2 lines, -6 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-buffer.cc View 1 4 chunks +10 lines, -0 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-buffer-private.hh View 1 3 chunks +32 lines, -2 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-font.cc View 1 9 chunks +176 lines, -68 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-font-private.hh View 7 chunks +101 lines, -45 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-ft.cc View 4 chunks +48 lines, -32 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-open-type-private.hh View 3 chunks +6 lines, -6 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-ot-font.cc View 5 chunks +48 lines, -96 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-ot-layout.cc View 1 chunk +1 line, -1 line 0 comments Download
M third_party/harfbuzz-ng/src/hb-ot-layout-common-private.hh View 3 chunks +13 lines, -2 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-ot-layout-gpos-table.hh View 3 chunks +8 lines, -4 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-ot-layout-gsub-table.hh View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-ot-layout-gsubgpos-private.hh View 1 12 chunks +20 lines, -16 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-ot-layout-private.hh View 6 chunks +103 lines, -31 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-ot-map-private.hh View 1 chunk +1 line, -15 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-ot-shape.cc View 17 chunks +67 lines, -35 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-ot-shape-complex-arabic.cc View 10 chunks +237 lines, -6 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-ot-shape-complex-default.cc View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-ot-shape-complex-hangul.cc View 2 chunks +5 lines, -4 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-ot-shape-complex-hebrew.cc View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-ot-shape-complex-indic.cc View 6 chunks +10 lines, -9 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-ot-shape-complex-myanmar.cc View 3 chunks +7 lines, -5 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-ot-shape-complex-private.hh View 1 chunk +9 lines, -0 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-ot-shape-complex-thai.cc View 4 chunks +4 lines, -3 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-ot-shape-complex-tibetan.cc View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-ot-shape-complex-use.cc View 5 chunks +7 lines, -12 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-ot-shape-fallback.cc View 4 chunks +70 lines, -1 line 0 comments Download
M third_party/harfbuzz-ng/src/hb-ot-shape-fallback-private.hh View 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-ot-shape-normalize.cc View 8 chunks +50 lines, -27 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-private.hh View 1 3 chunks +56 lines, -3 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-unicode-private.hh View 2 chunks +48 lines, -0 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-utf-private.hh View 5 chunks +25 lines, -21 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-version.h View 1 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 31 (13 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1476763003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1476763003/1
5 years ago (2015-11-25 10:42:33 UTC) #2
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/145912) win_chromium_rel_ng on ...
5 years ago (2015-11-25 11:12:08 UTC) #4
drott
rolling to 1.1.1
5 years ago (2015-11-25 11:33:32 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1476763003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1476763003/20001
5 years ago (2015-11-25 11:34:26 UTC) #8
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/146067)
5 years ago (2015-11-25 13:34:46 UTC) #10
drott
Rebaseline
5 years ago (2015-11-26 15:58:54 UTC) #11
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1476763003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1476763003/40001
5 years ago (2015-11-26 16:02:24 UTC) #13
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/140841)
5 years ago (2015-11-26 18:22:47 UTC) #15
ebraminio
The failure seems unrelated, probably it needs manually or forced merge
5 years ago (2015-11-27 04:29:16 UTC) #16
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1476763003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1476763003/60001
5 years ago (2015-11-27 10:00:25 UTC) #18
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years ago (2015-11-27 12:28:56 UTC) #20
kojii
lgtm
5 years ago (2015-11-30 09:31:56 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1476763003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1476763003/60001
5 years ago (2015-11-30 09:38:00 UTC) #23
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years ago (2015-11-30 10:55:49 UTC) #25
commit-bot: I haz the power
Failed to apply the patch.
5 years ago (2015-11-30 10:56:33 UTC) #26
commit-bot: I haz the power
Patchset 4 (id:??) landed as https://crrev.com/c3c69f0e2aefe7bfdf04cdf88883a24955112d64 Cr-Commit-Position: refs/heads/master@{#362116}
5 years ago (2015-11-30 10:56:52 UTC) #28
yurys
Looks like this change affected fast/writing-mode/Kusa-Makura-background-canvas.html: http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=fast%2Fwriting-mode%2FKusa-Makura-background-canvas.html&testType=layout-tests Please take a look if it just needs ...
5 years ago (2015-11-30 18:14:46 UTC) #30
drott
5 years ago (2015-11-30 18:28:45 UTC) #31
Message was sent while issue was closed.
>
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=fas...
> 
> Please take a look if it just needs rebaseline?

I saw you marked the test as flaky on Win and mentioned the bug that's already
assigned to me. I'll look into the test case there.

Powered by Google App Engine
This is Rietveld 408576698