Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(434)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1476473005: [Interpreter] Add support for compare operators to bytecode graph builder. (Closed)

Created:
5 years ago by mythria
Modified:
5 years ago
Reviewers:
oth, Michael Starzinger
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[Interpreter] Add support for compare operators to bytecode graph builder. Adds implementation and tests for compare operators to bytecode graph builder. BUG=v8:4280 LOG=N Committed: https://crrev.com/46401fcb1cc9b58b3e99477867e9863962d5ace9 Cr-Commit-Position: refs/heads/master@{#32280}

Patch Set 1 #

Patch Set 2 : Fixed compile error on linux_gcc bot. #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+175 lines, -12 lines) Patch
M src/compiler/bytecode-graph-builder.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/compiler/bytecode-graph-builder.cc View 1 chunk +21 lines, -10 lines 0 comments Download
M test/cctest/compiler/test-run-bytecode-graph-builder.cc View 1 2 chunks +150 lines, -0 lines 0 comments Download
M test/cctest/interpreter/test-interpreter.cc View 1 chunk +2 lines, -2 lines 1 comment Download

Messages

Total messages: 8 (2 generated)
mythria
Could you please review my changes. Thanks, Mythri
5 years ago (2015-11-25 13:48:43 UTC) #2
oth
lgtm https://codereview.chromium.org/1476473005/diff/20001/test/cctest/interpreter/test-interpreter.cc File test/cctest/interpreter/test-interpreter.cc (right): https://codereview.chromium.org/1476473005/diff/20001/test/cctest/interpreter/test-interpreter.cc#newcode1248 test/cctest/interpreter/test-interpreter.cc:1248: Token::Value::NE_STRICT, Token::Value::LT, Token::Value::LTE, Good catch.
5 years ago (2015-11-25 14:18:33 UTC) #3
Michael Starzinger
LGTM.
5 years ago (2015-11-25 14:52:00 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1476473005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1476473005/20001
5 years ago (2015-11-25 15:16:59 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years ago (2015-11-25 15:21:20 UTC) #7
commit-bot: I haz the power
5 years ago (2015-11-25 15:21:42 UTC) #8
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/46401fcb1cc9b58b3e99477867e9863962d5ace9
Cr-Commit-Position: refs/heads/master@{#32280}

Powered by Google App Engine
This is Rietveld 408576698