chrome/browser/ui/views/tabs/tab_strip.h - Issue 147623004: Tab close buttons can only be targeted with touch if the whole button is visible

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/tabs/tab_strip.h

Issue 147623004: Tab close buttons can only be targeted with touch if the whole button is visible (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: comments addressed Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/views/tabs/tab_strip.h

diff --git a/chrome/browser/ui/views/tabs/tab_strip.h b/chrome/browser/ui/views/tabs/tab_strip.h

index b4de10d2ad1f6ab83e37b621ab9e4ae50aefee32..5939564a0ec4409e384409c6e98730d2e354f524 100644

--- a/chrome/browser/ui/views/tabs/tab_strip.h

+++ b/chrome/browser/ui/views/tabs/tab_strip.h

@@ -268,6 +268,7 @@ class TabStrip : public views::View,

FRIEND_TEST_ALL_PREFIXES(TabDragControllerTest, GestureEndShouldEndDragTest);

friend class TabStripTest;

FRIEND_TEST_ALL_PREFIXES(TabStripTest, TabHitTestMaskWhenStacked);

+ FRIEND_TEST_ALL_PREFIXES(TabStripTest, ClippedTabCloseButton);

// Used during a drop session of a url. Tracks the position of the drop as

// well as a window used to highlight where the drop occurs.

« no previous file with comments | « chrome/browser/ui/views/tabs/tab.cc ('k') | chrome/browser/ui/views/tabs/tab_strip_unittest.cc » ('j') | no next file with comments »