Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(724)

Side by Side Diff: chrome/browser/ui/views/tabs/tab_strip.h

Issue 147623004: Tab close buttons can only be targeted with touch if the whole button is visible (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: comments addressed Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « chrome/browser/ui/views/tabs/tab.cc ('k') | chrome/browser/ui/views/tabs/tab_strip_unittest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_UI_VIEWS_TABS_TAB_STRIP_H_ 5 #ifndef CHROME_BROWSER_UI_VIEWS_TABS_TAB_STRIP_H_
6 #define CHROME_BROWSER_UI_VIEWS_TABS_TAB_STRIP_H_ 6 #define CHROME_BROWSER_UI_VIEWS_TABS_TAB_STRIP_H_
7 7
8 #include <vector> 8 #include <vector>
9 9
10 #include "base/compiler_specific.h" 10 #include "base/compiler_specific.h"
(...skipping 250 matching lines...) Expand 10 before | Expand all | Expand 10 after
261 private: 261 private:
262 typedef std::map<int, std::vector<Tab*> > TabsClosingMap; 262 typedef std::map<int, std::vector<Tab*> > TabsClosingMap;
263 263
264 class RemoveTabDelegate; 264 class RemoveTabDelegate;
265 265
266 friend class TabDragController; 266 friend class TabDragController;
267 friend class TabDragControllerTest; 267 friend class TabDragControllerTest;
268 FRIEND_TEST_ALL_PREFIXES(TabDragControllerTest, GestureEndShouldEndDragTest); 268 FRIEND_TEST_ALL_PREFIXES(TabDragControllerTest, GestureEndShouldEndDragTest);
269 friend class TabStripTest; 269 friend class TabStripTest;
270 FRIEND_TEST_ALL_PREFIXES(TabStripTest, TabHitTestMaskWhenStacked); 270 FRIEND_TEST_ALL_PREFIXES(TabStripTest, TabHitTestMaskWhenStacked);
271 FRIEND_TEST_ALL_PREFIXES(TabStripTest, ClippedTabCloseButton);
271 272
272 // Used during a drop session of a url. Tracks the position of the drop as 273 // Used during a drop session of a url. Tracks the position of the drop as
273 // well as a window used to highlight where the drop occurs. 274 // well as a window used to highlight where the drop occurs.
274 struct DropInfo { 275 struct DropInfo {
275 DropInfo(int drop_index, 276 DropInfo(int drop_index,
276 bool drop_before, 277 bool drop_before,
277 bool point_down, 278 bool point_down,
278 views::Widget* context); 279 views::Widget* context);
279 ~DropInfo(); 280 ~DropInfo();
280 281
(...skipping 352 matching lines...) Expand 10 before | Expand all | Expand 10 after
633 bool immersive_style_; 634 bool immersive_style_;
634 635
635 // Our observers. 636 // Our observers.
636 typedef ObserverList<TabStripObserver> TabStripObservers; 637 typedef ObserverList<TabStripObserver> TabStripObservers;
637 TabStripObservers observers_; 638 TabStripObservers observers_;
638 639
639 DISALLOW_COPY_AND_ASSIGN(TabStrip); 640 DISALLOW_COPY_AND_ASSIGN(TabStrip);
640 }; 641 };
641 642
642 #endif // CHROME_BROWSER_UI_VIEWS_TABS_TAB_STRIP_H_ 643 #endif // CHROME_BROWSER_UI_VIEWS_TABS_TAB_STRIP_H_
OLDNEW
« no previous file with comments | « chrome/browser/ui/views/tabs/tab.cc ('k') | chrome/browser/ui/views/tabs/tab_strip_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698