buildbot UI: add linkification of Rietveld issue URL to build page.

masters/master.chromium/templates/build.html

Index: masters/master.chromium/templates/build.html
diff --git a/masters/master.chromium/templates/build.html b/masters/master.chromium/templates/build.html
index b52e264d1b29e2bf6f72d6fec20a5dfe40ec2ea4..7dc7ca958ae8de2a0e99381b576259f32bb30122 100644
--- a/masters/master.chromium/templates/build.html
+++ b/masters/master.chromium/templates/build.html
@@ -23,7 +23,7 @@ Build #{{ b.getNumber() }}
   {% endif %}
 
   {{ current_step }}
-  
+
   {% if authz.advertiseAction('stopBuild') %}
     <h2>Stop Build</h2>
     {{ forms.stop_build(build_url+"/stop", authz, on_all=False, short=False, label='This Build') }}
@@ -31,10 +31,10 @@ Build #{{ b.getNumber() }}
 {% else %}
   <h2>Results:</h2>
 
-  <p class="{{ result_css }} result">   
+  <p class="{{ result_css }} result">
     {{ b.getText()|join(' ')|capitalize }}
   </p>
-   
+
   {% if b.getTestResults() %}
     <h3><a href="{{ tests_link }}"/></h3>
   {% endif %}
@@ -83,13 +83,13 @@ Build #{{ b.getNumber() }}
  # TODO: turn this into a table, or some other sort of definition-list
  # that doesn't take up quite so much vertical space
  #}
-   
+
 <h2>BuildSlave:</h2>
-  
-{% if slave_url %}  
+
+{% if slave_url %}
   <a href="{{ slave_url|e }}">{{ b.getSlavename()|e }}</a>
 {% else %}
-  {{ b.getSlavename()|e }} 
+  {{ b.getSlavename()|e }}
 {% endif %}
 
 <h2>Reason:</h2>
@@ -171,6 +171,9 @@ Build #{{ b.getNumber() }}
 <table class="info BuildProperties" width="100%">
 <tr><th>Name</th><th>Value</th><th>Source</th></tr>
 
+{% for p in properties %}{% if p.name == 'rietveld' %} {% set rietveld_url = p.value %}{% endif %}
+{% else %}{% set rietveld_url = '' %}{% endfor %}

[Sergiy Byelozyorov, 2015/11/26 15:10:34]

please structure it with indents, e.g.

{% for p in properties %}
  {% if p.name == 'rietveld' %}
    {% set rietveld_url = p.value %}

when you do you'll discover a bug :-)

make similar change to
masters/master.tryserver.chromium.linux/templates/build.html

[tandrii(chromium), 2015/11/26 15:18:37]

Done, but I don't see a bug.

[Sergiy Byelozyorov, 2015/11/27 12:17:13]

else for for? afaik, this only works in python

+
 {% for p in properties %}
   <tr class="{{ loop.cycle('alt', '') }}">
     <td class="left">{{ p.name|e }}</td>
@@ -182,6 +185,8 @@ Build #{{ b.getNumber() }}
       {% endif %}">
     {% if p.short_value %}
       {{ p.short_value|e }} .. [property value too long]
+    {% elif p.name == 'issue' and rietveld_url %}
+      <a style="color: red" href="{{ (rietveld_url + '/' + p.value)|e }} ">{{ p.value|e }}</a>
     {% else %}
       {{ p.value|e }}
     {% endif %}
@@ -222,7 +227,7 @@ Build #{{ b.getNumber() }}
 </div>
 
 <br style="clear:both"/>
-  
+
 {% if ss.changes %}
 <div class="column">
   <h2>All Changes:</h2>
@@ -233,9 +238,9 @@ Build #{{ b.getNumber() }}
     </li>
   {% else %}
     <li>no changes</li>
-  {% endfor %}  
+  {% endfor %}
   </ol>
-</div> 
+</div>
 {% endif %}
 
 {% endblock %}