Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(382)

Issue 147593006: Refine error code returned by ServiceWorkerVersion::StartWorker (e.g. PROCESS_NOT_FOUND etc) (Closed)

Created:
6 years, 10 months ago by kinuko
Modified:
6 years, 10 months ago
Reviewers:
alecflett
CC:
chromium-reviews, tzik, jam, nhiroki, joi+watch-content_chromium.org, darin-cc_chromium.org, horo+watch_chromium.org, kinuko+watch
Visibility:
Public.

Description

Refine error code returned by ServiceWorkerVersion::StartWorker (e.g. PROCESS_NOT_FOUND etc) BUG=313530 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=247845

Patch Set 1 #

Patch Set 2 : test fix #

Patch Set 3 : #

Messages

Total messages: 8 (0 generated)
kinuko
Hopefully these changes make debugging in a near future slightly more easy? PTL
6 years, 10 months ago (2014-01-29 09:57:57 UTC) #1
alecflett
lgtm Great, this will make a lot of future code cleaner..
6 years, 10 months ago (2014-01-29 17:27:06 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinuko@chromium.org/147593006/70001
6 years, 10 months ago (2014-01-29 17:27:15 UTC) #3
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) telemetry_perf_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=253673
6 years, 10 months ago (2014-01-29 21:36:57 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinuko@chromium.org/147593006/70001
6 years, 10 months ago (2014-01-29 22:37:38 UTC) #5
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-01-30 03:04:26 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinuko@chromium.org/147593006/70001
6 years, 10 months ago (2014-01-30 03:12:02 UTC) #7
commit-bot: I haz the power
6 years, 10 months ago (2014-01-30 05:43:11 UTC) #8
Message was sent while issue was closed.
Change committed as 247845

Powered by Google App Engine
This is Rietveld 408576698