Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(259)

Side by Side Diff: content/browser/service_worker/service_worker_registration_status.cc

Issue 147593006: Refine error code returned by ServiceWorkerVersion::StartWorker (e.g. PROCESS_NOT_FOUND etc) (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/browser/service_worker/service_worker_registration_status.h" 5 #include "content/browser/service_worker/service_worker_registration_status.h"
6 6
7 #include "base/logging.h" 7 #include "base/logging.h"
8 #include "base/strings/utf_string_conversions.h" 8 #include "base/strings/utf_string_conversions.h"
9 9
10 namespace content { 10 namespace content {
(...skipping 14 matching lines...) Expand all
25 case SERVICE_WORKER_ERROR_START_WORKER_FAILED: 25 case SERVICE_WORKER_ERROR_START_WORKER_FAILED:
26 case SERVICE_WORKER_ERROR_INSTALL_WORKER_FAILED: 26 case SERVICE_WORKER_ERROR_INSTALL_WORKER_FAILED:
27 *error_type = WebServiceWorkerError::InstallError; 27 *error_type = WebServiceWorkerError::InstallError;
28 return; 28 return;
29 29
30 case SERVICE_WORKER_ERROR_ACTIVATE_WORKER_FAILED: 30 case SERVICE_WORKER_ERROR_ACTIVATE_WORKER_FAILED:
31 *error_type = WebServiceWorkerError::ActivateError; 31 *error_type = WebServiceWorkerError::ActivateError;
32 return; 32 return;
33 33
34 case SERVICE_WORKER_ERROR_ABORT: 34 case SERVICE_WORKER_ERROR_ABORT:
35 case SERVICE_WORKER_ERROR_IPC_FAILED:
35 case SERVICE_WORKER_ERROR_FAILED: 36 case SERVICE_WORKER_ERROR_FAILED:
36 case SERVICE_WORKER_ERROR_PROCESS_NOT_FOUND: 37 case SERVICE_WORKER_ERROR_PROCESS_NOT_FOUND:
37 // Unexpected, or should bail out before calling this, or we don't 38 // Unexpected, or should bail out before calling this, or we don't
38 // have a corresponding blink error code yet. 39 // have a corresponding blink error code yet.
39 break; // Fall through to NOTREACHED(). 40 break; // Fall through to NOTREACHED().
40 } 41 }
41 NOTREACHED() << "Got unexpected error code: " 42 NOTREACHED() << "Got unexpected error code: "
42 << status << " " << ServiceWorkerStatusToString(status); 43 << status << " " << ServiceWorkerStatusToString(status);
43 } 44 }
44 45
45 } // namespace content 46 } // namespace content
OLDNEW
« no previous file with comments | « content/browser/service_worker/service_worker_browsertest.cc ('k') | content/browser/service_worker/service_worker_version.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698