Implement new dangerous download reporting dialog for UNCOMMON_DOWNLOAD, in Views

chrome/browser/ui/views/download/download_shelf_view.h

Index: chrome/browser/ui/views/download/download_shelf_view.h
diff --git a/chrome/browser/ui/views/download/download_shelf_view.h b/chrome/browser/ui/views/download/download_shelf_view.h
index f5362679f1e832bfb94fdb59a7f57e91d5c9aead..49d771d2e0c8c733a661b00dcfe3318fc6991bb6 100644
--- a/chrome/browser/ui/views/download/download_shelf_view.h
+++ b/chrome/browser/ui/views/download/download_shelf_view.h
@@ -10,6 +10,7 @@
 #include "base/basictypes.h"
 #include "base/compiler_specific.h"
 #include "chrome/browser/download/download_shelf.h"
+#include "chrome/browser/ui/views/frame/browser_view.h"
 #include "ui/gfx/animation/animation_delegate.h"
 #include "ui/views/accessible_pane_view.h"
 #include "ui/views/controls/button/button.h"
@@ -17,7 +18,6 @@
 #include "ui/views/mouse_watcher.h"
 
 class Browser;
-class BrowserView;
 class DownloadItemView;
 
 namespace content {
@@ -56,6 +56,9 @@ class DownloadShelfView : public views::AccessiblePaneView,
   // i.e. the |browser_|.
   content::PageNavigator* GetNavigator();

[Peter Kasting, 2014/02/04 21:56:33]

Nit: While here: There's no need for this function.  All callers can just call
browser() instead, which is also public.  Nuke this.

Note: If this comment and/or the last one in this file would result in large
diffs, feel free to do them as separate CLs.

[felt, 2014/02/04 23:37:22]

I'll send a follow-up CL for this.

 
+  // Returns the parent_.
+  BrowserView* GetParentWindowView();

[Peter Kasting, 2014/02/04 21:56:33]

Nit: This function should be inlined and named like:

  BrowserView* get_parent() { return parent_; }

[felt, 2014/02/04 23:37:22]

Done.

+
   // Implementation of View.
   virtual gfx::Size GetPreferredSize() OVERRIDE;
   virtual void Layout() OVERRIDE;